Skip to content
This repository has been archived by the owner on Jul 1, 2022. It is now read-only.

Add members, tracks and associatedMedia #9

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

listenaddress
Copy link
Member

No description provided.

Copy link
Collaborator

@oftenfrequent oftenfrequent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seeing the syntax in practice brings up some thoughts.

  1. The naming scheme for propArrays vs argument accepted in the helper function.
    A) Should the property be plural members but the helper functions be singular addMember and accept a coala-ip instance of person in this instance.
    or
    B) Should any propArray helper functions accept only arrays containing at least 1 coala-ip instance without throwing an error.
    I am partial to the latter.

  2. This helps us in the short term gain parity over our schema on the front end and db however I'm not sure it solves the issue fully enough. It seems as though we should migrate all propArrays to the updated syntax for consistency's sake.

Let me know your thoughts.

@listenaddress
Copy link
Member Author

Ah good catch! I meant to revisit that too. I like B and migrating the other propArrays as well.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants