Skip to content

fix: 모달 하단이 카카오 하단바에 가려지는 문제 해결을 위해 pb추가#26

Merged
dasosann merged 1 commit intomainfrom
fix/display
Feb 11, 2026
Merged

fix: 모달 하단이 카카오 하단바에 가려지는 문제 해결을 위해 pb추가#26
dasosann merged 1 commit intomainfrom
fix/display

Conversation

@dasosann
Copy link
Contributor

@dasosann dasosann commented Feb 11, 2026

PR Type

Bug fix


Description

  • 모달 하단에 패딩 추가하여 카카오 하단바 겹침 문제 해결

  • DrawerContent에 pb-[32px] 클래스 적용


Diagram Walkthrough

flowchart LR
  A["LoginActionSection<br/>DrawerContent"] -- "pb-[32px] 추가" --> B["모달 하단 여백<br/>확보"]
  B -- "결과" --> C["카카오 하단바<br/>겹침 해결"]
Loading

File Walkthrough

Relevant files
Bug fix
LoginActionSection.tsx
모달 하단 패딩 추가                                                                                           

app/_components/LoginActionSection.tsx

  • DrawerContent className에 pb-[32px] 패딩 클래스 추가
  • 모달 하단이 카카오 하단바에 가려지는 UI 문제 해결
+1/-1     


✨ Describe tool usage guide:

Overview:
The describe tool scans the PR code changes, and generates a description for the PR - title, type, summary, walkthrough and labels. The tool can be triggered automatically every time a new PR is opened, or can be invoked manually by commenting on a PR.

When commenting, to edit configurations related to the describe tool (pr_description section), use the following template:

/describe --pr_description.some_config1=... --pr_description.some_config2=...

With a configuration file, use the following template:

[pr_description]
some_config1=...
some_config2=...
Enabling\disabling automation
  • When you first install the app, the default mode for the describe tool is:
pr_commands = ["/describe", ...]

meaning the describe tool will run automatically on every PR.

  • Markers are an alternative way to control the generated description, to give maximal control to the user. If you set:
pr_commands = ["/describe --pr_description.use_description_markers=true", ...]

the tool will replace every marker of the form pr_agent:marker_name in the PR description with the relevant content, where marker_name is one of the following:

  • type: the PR type.
  • summary: the PR summary.
  • walkthrough: the PR walkthrough.
  • diagram: the PR sequence diagram (if enabled).

Note that when markers are enabled, if the original PR description does not contain any markers, the tool will not alter the description at all.

Custom labels

The default labels of the describe tool are quite generic: [Bug fix, Tests, Enhancement, Documentation, Other].

If you specify custom labels in the repo's labels page or via configuration file, you can get tailored labels for your use cases.
Examples for custom labels:

  • Main topic:performance - pr_agent:The main topic of this PR is performance
  • New endpoint - pr_agent:A new endpoint was added in this PR
  • SQL query - pr_agent:A new SQL query was added in this PR
  • Dockerfile changes - pr_agent:The PR contains changes in the Dockerfile
  • ...

The list above is eclectic, and aims to give an idea of different possibilities. Define custom labels that are relevant for your repo and use cases.
Note that Labels are not mutually exclusive, so you can add multiple label categories.
Make sure to provide proper title, and a detailed and well-phrased description for each label, so the tool will know when to suggest it.

Inline File Walkthrough 💎

For enhanced user experience, the describe tool can add file summaries directly to the "Files changed" tab in the PR page.
This will enable you to quickly understand the changes in each file, while reviewing the code changes (diffs).

To enable inline file summary, set pr_description.inline_file_summary in the configuration file, possible values are:

  • 'table': File changes walkthrough table will be displayed on the top of the "Files changed" tab, in addition to the "Conversation" tab.
  • true: A collapsable file comment with changes title and a changes summary for each file in the PR.
  • false (default): File changes walkthrough will be added only to the "Conversation" tab.
Utilizing extra instructions

The describe tool can be configured with extra instructions, to guide the model to a feedback tailored to the needs of your project.

Be specific, clear, and concise in the instructions. With extra instructions, you are the prompter. Notice that the general structure of the description is fixed, and cannot be changed. Extra instructions can change the content or style of each sub-section of the PR description.

Examples for extra instructions:

[pr_description]
extra_instructions="""- The PR title should be in the format: '<PR type>: <title>'
- The title should be short and concise (up to 10 words)
- ...
"""

Use triple quotes to write multi-line instructions. Use bullet points to make the instructions more readable.

More PR-Agent commands

To invoke the PR-Agent, add a comment using one of the following commands:

  • /review: Request a review of your Pull Request.
  • /describe: Update the PR title and description based on the contents of the PR.
  • /improve [--extended]: Suggest code improvements. Extended mode provides a higher quality feedback.
  • /ask <QUESTION>: Ask a question about the PR.
  • /update_changelog: Update the changelog based on the PR's contents.
  • /help_docs <QUESTION>: Given a path to documentation (either for this repository or for a given one), ask a question.
  • /add_docs 💎: Generate docstring for new components introduced in the PR.
  • /generate_labels 💎: Generate labels for the PR based on the PR's contents.
  • /analyze 💎: Automatically analyzes the PR, and presents changes walkthrough for each component.

See the tools guide for more details.
To list the possible configuration parameters, add a /config comment.

See the describe usage page for a comprehensive guide on using this tool.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @dasosann, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

이 풀 리퀘스트는 모바일 환경에서 모달의 하단 내용이 카카오 하단바에 의해 가려지는 사용자 인터페이스 문제를 해결합니다. DrawerContent 컴포넌트에 적절한 하단 패딩을 추가하여, 모달의 모든 내용이 사용자에게 명확하게 보이도록 개선했습니다.

Highlights

  • UI 수정: 모달 하단이 카카오 하단바에 가려지는 문제를 해결하기 위해 DrawerContent 컴포넌트에 하단 패딩(pb-[32px])을 추가했습니다.
Changelog
  • app/_components/LoginActionSection.tsx
    • DrawerContent 컴포넌트의 classNamepb-[32px] 속성을 추가하여 하단 패딩을 적용했습니다.
Activity
  • 현재까지 기록된 활동이 없습니다.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@dasosann dasosann merged commit e254d15 into main Feb 11, 2026
2 checks passed
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

안녕하세요. 모달 하단이 카카오 하단바에 가려지는 문제를 해결하기 위해 패딩을 추가하신 변경사항 잘 확인했습니다. UI 버그를 수정해주셔서 감사합니다. 코드의 일관성과 유지보수성을 높이기 위해 한 가지 작은 개선점을 제안드립니다. 아래 리뷰 코멘트를 확인해주세요.

<DrawerContent
showHandle={false}
className="mx-auto flex h-[44.33vh] w-full flex-col items-center px-4 pt-6 md:max-w-[430px]"
className="mx-auto flex h-[44.33vh] w-full flex-col items-center px-4 pt-6 pb-[32px] md:max-w-[430px]"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Tailwind CSS의 임의 값(arbitrary value) 대신 디자인 시스템의 스페이싱 단위를 사용하는 것이 일관성 및 유지보수 측면에서 더 좋습니다. 32px는 Tailwind의 기본 스페이싱 스케일에서 8에 해당하므로 (2rem), pb-[32px] 대신 pb-8을 사용하시는 것을 권장합니다. 이렇게 하면 다른 컴포넌트들과의 간격 일관성을 유지하고, 향후 디자인 시스템 변경에 더 유연하게 대응할 수 있습니다.

Suggested change
className="mx-auto flex h-[44.33vh] w-full flex-col items-center px-4 pt-6 pb-[32px] md:max-w-[430px]"
className="mx-auto flex h-[44.33vh] w-full flex-col items-center px-4 pt-6 pb-8 md:max-w-[430px]"
References
  1. 스타일링 시 Tailwind CSS의 기본 유틸리티 클래스 사용을 우선해야 합니다. 임의 값을 사용하는 것보다 테마에 정의된 스페이싱 단위를 사용하면 코드의 일관성과 유지보수성이 향상됩니다. (link)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant