FPS-URB-RCC Stage-1 bug fixes #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…f_urban.F is underestimating the value by a factor of emissivty of the wall, EPSG, as it is multiplied twice. I corrected the equation in the aforementioned module. (wrf-model#2016) TYPE: Bug fix KEYWORDS: Longwave flux, radiation/energy balance, Surface temperature, Urban climate, SLUCM SOURCE: Parag Joshi (Brookhaven National Lab), Katia Lamer (Brookhaven National Lab) DESCRIPTION OF CHANGES: Problem: The net long wave fluxes absorbed by the building walls is being underestimated due to multiplication of the emissivity twice in the equation. The command/lines that evaluate RB2 in the module_sf_urban.F (Lines 1300 and 1419 of WRF version-4.5.2) reflect the net long wave fluxes absorbed by building walls. Solution: The code has been corrected by referring to the equation A9 of in the article, Kusaka & Kimora 2004, Journal of Applied Meteorology. ISSUE: For use when this PR closes an issue. Fixes wrf-model#2011 LIST OF MODIFIED FILES: M module_sf_urban.F TESTS CONDUCTED: 1. Tests were conducted by the LSM group at NCAR/RAL. 2. It passed Jenkins tests. RELEASE NOTE: Correcting the net long wave fluxes for application in modeling urban climate using Single Layer Urban Canopy Model (SLUCM). It slightly improved 2-m temperature in urban area.
TYPE: bug fix KEYWORDS: module_sf_bep_bem.F, loop index, debugging-crash SOURCE: L. Fita (UBA/CIMA/IFAECI) DESCRIPTION OF CHANGES: Problem: The loop index in line 1600 of subroutine module_sf_bep_bem.F should be up to `nzu`, instead of `nz_um`. Solution: This PR fixes the index. ISSUE: For use when this PR closes an issue. Fixes wrf-model#2194 LIST OF MODIFIED FILES: M phys/module_sf_bep_bem.F TESTS CONDUCTED: 1. Code was modified and recompiled in serial debug mode and it did not crashed 2. The Jenkins tests are all passing. RELEASE NOTE: This PR fixed a loop index error in bep_bem urban code.
…el#1969) TYPE: enhancement KEYWORDS: urban, parameter SOURCE: Reported by Benjamin Fersch (Karlsruhe Institute of Technology, Germany), fixed by Alberto Martilli (CIEMAT, Spain) DESCRIPTION OF CHANGES: Problem: Current urban LCZ parameter table includes some unreasonable values for urban morphology (e.g., too large road width) and thermal properties (e.g., CAPR, CAPB, CAPG, AKSR, AKPB, AKPG). The LCZ classification is mainly a classification based on morphology, rather than thermal properties, so it should use the same thermal properties for different LCZs unless users have specific information from other local data sources. Solution: Use morphological parameters correspond to mid-range values of Stewart and Oke 2012, and all the LCZ classes have the same thermal properties. ISSUE: [For use when this PR closes an issue.](wrf-model#1954) LIST OF MODIFIED FILES: URBPARM_LCZ.TBL TESTS CONDUCTED: 1. The mods fix the problem. 2. It passed regression tests. RELEASE NOTE: Update urban LCZ parameter table (URBPARM_LCZ.TBL) with more reasonable values.
…l in Noah-MP (wrf-model#1990) TYPE: bug fix KEYWORDS: LAI, urban, Noah-MP SOURCE: Cenlin He (NCAR/RAL) DESCRIPTION OF CHANGES: Problem: Before bug fix, Noah-MP (v4.5 and earlier versions) initializes leaf mass from the table parameter based on land type. However, this causes model crash if the LCZ capability is activated for urban pixel, because the LCZ land type index (51-61) is out of the MODIS or USGS land type number. This code is in module_sf_noahmpdrv.F file. Solution: Add an if-statement to assign default natural vegetation type for urban pixels with large land type index to represent rural portion of the urban pixel. This is related to a reported Noah-MP issue (NCAR/noahmp#104). LIST OF MODIFIED FILES: phys/noahmp/drivers/wrf/module_sf_noahmpdrv.F TESTS CONDUCTED: - The mods fix the problem - It passed the regression tests. RELEASE NOTE: This PR fixed a bug in Noah-MP for uninitialized leaf area index when LCZ is used.
) TYPE: bug fix KEYWORDS: Noah-MP, vegetation fraction scaling SOURCE: Cenlin He (NCAR/RAL) DESCRIPTION OF CHANGES: A bug fix for Noah-MP related processes: There is a bug in vegetation fraction (FVEG) scaling for stomata resistance calculation (NCAR/noahmp#92) and canopy interception calculation (NCAR/noahmp#91). LIST OF MODIFIED FILES: list of changed files (use `git diff --name-status master` to get formatted list): phys/noahmp/src/module_sf_noahmplsm.F TESTS CONDUCTED: 1. Tested successfully in NCAR Cheyenne HPC for 13-km run over the entire CONUS region 2. The Jenkins tests are all passing. RELEASE NOTE: Noah-MP bug fix for vegetation fraction scaling.
TYPE: bug fix KEYWORDS: surface layer, latent heat flux limit SOURCE: David Robertson, Rutgers University DESCRIPTION OF CHANGES: Problem: Arbitrary limitation in the computation of QFX and HFX in modules module_sf_sfclay.F and module_sf_sfclayrev.F that affects the computation latent heat fluxes and sensible heat flux in coastal areas that limit fog layers. Solution: The zero downward latent heat flux limit is removed. LIST OF MODIFIED FILES: M phys/module_sf_sfclay.F M phys/module_sf_sfclayrev.F TESTS CONDUCTED: - Ran the coupled WRF-ROMS standard test case for Hurricane Irene. - It passed regression tests. RELEASE NOTE: This PR removed zero negative latent heat flux limit (atmosphere to water) in the revised MM5 and original MM5 surface layer schemes.
…SGS urban category. (wrf-model#2153) TYPE: bug fix KEYWORDS: LCZ, USGS SOURCE: Lukas Pilz (Heidelberg University) DESCRIPTION OF CHANGES: Problem: As shown in wrf-model#2152, for USGS data the wrfinput LU_INDEX field has major differences to the met_em LU_INDEX field. Cells in LU_INDEX which have LCZ categories (>30) were overwritten with the default USGS urban category (1) where FRC_URB2D > 0.5. Solution: Add a check similar to the MODIS case above. ISSUE: Fixes wrf-model#2152 LIST OF MODIFIED FILES: M dyn_em/module_initialize_real.F TESTS CONDUCTED: 1. Did local tests, the only differences between wrfinput and met_em which remain are changing LU_INDEX 28 to 16, which is a water body redesignation as to my knowledge. 2. Jenkins tests have passed. RELEASE NOTE: Bug fix for wrfinput where LCZ urban cells in LU_INDEX were overwritten with default USGS urban category.
TYPE: bug fix KEYWORDS: module_sf_bep_bem.F, loop index, debugging-crash SOURCE: L. Fita (UBA/CIMA/IFAECI) DESCRIPTION OF CHANGES: Problem: The loop index in line 1600 of subroutine module_sf_bep_bem.F should be up to `nzu`, instead of `nz_um`. Solution: This PR fixes the index. ISSUE: For use when this PR closes an issue. Fixes wrf-model#2194 LIST OF MODIFIED FILES: M phys/module_sf_bep_bem.F TESTS CONDUCTED: 1. Code was modified and recompiled in serial debug mode and it did not crashed 2. The Jenkins tests are all passing. RELEASE NOTE: This PR fixed a loop index error in bep_bem urban code.
Bug affecting calculation of t2veg_urb2d in module_sf_noahdrv.F is fixed.
In module_surface_driver.F near-surface diagnostics (e.g.T2) set to be equal to the weighted average of the vaules over the urban fraction (e.g. T2G_URB2D) and vegetation fraction (e.g. T2VEG_URB2D). NOTE: TCAN_URB2D as it is now is basically the temperature of the lowest model level - not the temperature of the urban canyon. Defintion of this TCAN_URB2D is opened to be redefined in the future if needed. SLUCM is having a different approct to defind this temperature.
AndresSimon
approved these changes
May 14, 2025
AndresSimon
approved these changes
May 14, 2025
jesusff
added a commit
to CORDEX-WRF-community/noahmp
that referenced
this pull request
May 28, 2025
Bug fixes paired with CORDEX-WRF-community/WRF#4
Resolving conflicts before merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix of several important bug fixes for FPS-URB-RCC Stage-1
TYPE: bug fix
KEYWORDS: 5 to 10 words related to commit, separated by commas
SOURCE: fps-urb-rcc
DESCRIPTION OF CHANGES:
The problems are listed in CORDEX-WRF-community/fps-urb-rcc#8
ISSUE:
Fixes CORDEX-WRF-community/fps-urb-rcc#8
LIST OF MODIFIED FILES: list of changed files (use
git diff --name-status v4.5.1-cwcto get formatted list)TESTS CONDUCTED:
RELEASE NOTE:
Applies fixes from WRF v4.6.0:
Applies fixes from WRF v4.7.0:
noahMP fixes:
Fixes to bugs found during BEP-BEM development (#2):