Set gregorian calednar correctly for CICE #112
Conversation
This change sets the 'time:units' and the 'time:calendar'' attributes of the history output consistent with the nuopc.runconfig file Patch is cherry-picked from CICE-Consortium/CICE#936
|
Yeah correct. I captured it in #113 and might do a batch ice_in update at some point? |
| add_patched_source(OM3_cice CICE/cicecore/drivers/nuopc/cmeps/ice_mesh_mod.F90) | ||
| add_patched_source(OM3_cice CICE/cicecore/drivers/nuopc/cmeps/ice_comp_nuopc.F90) |
There was a problem hiding this comment.
@micaeljtoliveira - is there a neater syntax than this for adding multiple patched sources?
There was a problem hiding this comment.
No, not really. If you have many files to patch then it might be worth putting them in a list and loop over the list contents. Something like this:
list(APPEND FilesToPatch CICE/cicecore/drivers/nuopc/cmeps/ice_mesh_mod.F90 CICE/cicecore/drivers/nuopc/cmeps/ice_comp_nuopc.F90)
foreach(FILE IN LISTS FilesToPatch)
add_patched_source(OM3_cice ${FILE})
endforeach()
Another option would be to add a variant of add_patched_source that takes multiple files:
add_patched_source(OM3_cice CICE/cicecore/drivers/nuopc/cmeps/ice_mesh_mod.F90 CICE/cicecore/drivers/nuopc/cmeps/ice_comp_nuopc.F90)IMO, none of them looks much neater than what you have here, but happy to hear other opinions.
There was a problem hiding this comment.
Ok thanks - ill leave it alone :)
| + if (calendar_type == ice_calendar_gregorian) then | ||
| + use_leap_years = .true. | ||
| + else | ||
| + use_leap_years = .false. ! no_leap calendars | ||
| + endif |
There was a problem hiding this comment.
This can be made more compact:
| + if (calendar_type == ice_calendar_gregorian) then | |
| + use_leap_years = .true. | |
| + else | |
| + use_leap_years = .false. ! no_leap calendars | |
| + endif | |
| + use_leap_years = calendar_type == ice_calendar_gregorian |
There was a problem hiding this comment.
Oh good pickup! I'm also going to leave this as is because we already committed this to cice-main :)
This change sets the 'time:units' and the 'time:calendar'' attributes of the history output consistent with the nuopc.runconfig file
Patch is cherry-picked from CICE-Consortium/CICE#936
Closes #111