Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to install components as libraries #80

Merged
merged 2 commits into from
Nov 29, 2023

Conversation

micaeljtoliveira
Copy link
Contributor

The user now can set the -DOM3_LIB_INSTALL option to install the following libraries:

  • access-common: common functions needed by all components (share, timing, nuopc_cap_share)
  • access-mom6: MOM6
  • access-cice: CICE
  • access-ww3: WW3
  • access-cdeps-*: all the different data models, each as a separate library
  • access-cmeps: the mediator (this excludes the nuopc_cap_share modules and all the driver stuff)

This will also install the Fortran modules.

@micaeljtoliveira micaeljtoliveira added enhancement New feature or request build system Build system labels Oct 25, 2023
@micaeljtoliveira micaeljtoliveira added this to the 0.3.x milestone Oct 25, 2023
@micaeljtoliveira micaeljtoliveira self-assigned this Oct 25, 2023
@micaeljtoliveira
Copy link
Contributor Author

@harshula Would you mind having a look at this PR?

Copy link
Collaborator

@harshula harshula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did an in-person review. Looks good. My only suggestion was to consider not bundling nuopc_cap_share, timing and share libraries into one library. They are apparently from separate source repositories and are separate libraries.

MOM6/CMakeLists.txt Outdated Show resolved Hide resolved
@micaeljtoliveira
Copy link
Contributor Author

My only suggestion was to consider not bundling nuopc_cap_share, timing and share libraries into one library. They are apparently from separate source repositories and are separate libraries.

@harshula I ended up by separating the libraries, as otherwise I was not able to correctly export the corresponding CMake targets (CMake is complicated...)

@micaeljtoliveira micaeljtoliveira merged commit e7ebf6c into main Nov 29, 2023
2 checks passed
@micaeljtoliveira micaeljtoliveira deleted the cmake_lib_install branch November 29, 2023 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build system Build system enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants