Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modified CAN read/write to work with classical CAN #36

Merged
merged 1 commit into from
Aug 16, 2024

Conversation

kamelfakihh
Copy link
Collaborator

Fixed issue with write operation on the CAN socket. The operation expects 16 bytes of data when CAN_RAW_FD_FRAMES socket option is not set and 72 bytes with the flag set. This caused the application to fail without --fd flag as it always tries to write 72 bytes.

Copy link
Collaborator

@nayakned nayakned left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nayakned nayakned merged commit e7fba30 into COVESA:main Aug 16, 2024
1 check passed
@nayakned nayakned deleted the bugfix/can-fd branch August 16, 2024 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants