Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the crashing of acf-can-listener when receiving other ACF packe… #39

Merged
merged 2 commits into from
Sep 4, 2024

Conversation

nayakned
Copy link
Collaborator

@nayakned nayakned commented Sep 3, 2024

…ts in parallel.

The acf-can-listener crashes when the raw socket receives other 1722 frames which are not ACF_CAN. But there are scenarios in which these frames should just be excluded/ignored and the listener should continue. This PR should enable such scenarios.

Copy link
Collaborator

@SebastianSchildt SebastianSchildt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works, so this is an improvement. I would suggest not (always) printing a scary error message, because I assume it is common to have other subtypes sharing the same medium?

@nayakned nayakned merged commit 89cf5a6 into COVESA:main Sep 4, 2024
1 check passed
@nayakned nayakned deleted the fix/can_examples branch September 4, 2024 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants