Allow static libs #27
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
we will check this change internally to see if this is causing any other problems |
Remove SHARED option from add_library to allow static libs, CMake then respects the standard BUILD_SHARED_LIBS option. Set the default value of BUILD_SHARED_LIBS to ON. Remove FactoryDeinit DEINITIALIZER, since it can be called after the runtime has been destroyed when statically linked, causing abort/segfault. Also as it is anyway not called via dlclose and CommonAPI::Runtime when dynamically linked.
hefroy
force-pushed
the
allow-static-libs
branch
from
968e406
to
ce36c05
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove SHARED option from add_library to allow static libs, CMake then respects the standard BUILD_SHARED_LIBS option. Set the default value of BUILD_SHARED_LIBS to ON.
Remove FactoryDeinit DEINITIALIZER, since it can be called after the runtime has been destroyed when statically linked, causing abort/segfault. Also as it is anyway not called via dlclose and CommonAPI::Runtime when dynamically linked.