Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert setting the default width of a serialized enumeration #37

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Revert setting the default width of a serialized enumeration #37

wants to merge 1 commit into from

Commits on Jan 19, 2024

  1. Revert setting the default width of a serialized enumeration 

    Setting the width as this code did narrows the enumeration value when it
isn't set to the default and a deployment object is unused.

e.g. With that static_cast, even the enumeration is a uint32_t for
example, it would be narrowed to a uint8_t and serialization would fail.
    @kheaactua
    kheaactua committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    b207e44 View commit details
    Browse the repository at this point in the history