When testing a cycle event, calling application_impl::stop_offer_event is invalid. #666

[hjkcst]

When testing a cycle event, calling application_impl::stop_offer_event is invalid. #666

See bug#666 for details of the issue.

[007herelsp]

I think this modification is dangerous,

[hjkcst]

Do you have a better way to solve this problem?

[hjkcst]

Does anyone know who is required to review and merge code after committing changes? What is the process like?

[007herelsp]

@hjkcst Can you provide the test code

[hjkcst]

@hjkcst Can you provide the test code
Sorry, the specific code may not be convenient to disclose, you can refer to the test process in this issue, run the stop_offer_event call, you can see the problem.
#666

[007herelsp]

void event::update_cbk(boost::system::error_code const &_error) added the is_provided_ detection, which is used to exit the cycle_timer

[hjkcst]

void event::update_cbk(boost::system::error_code const &_error) added the is_provided_ detection, which is used to exit the cycle_timer

Hello,007herelsp

I think this modification cannot completely delete the reference count of the pointer corresponding to cycle event, which means that cycle event instances still exist. The function of application_impl::stop_offer_event is to unregister the cycle event, that is, to delete it rather than stop it.

thanks,jinkuan

[007herelsp]

implementation/routing/src/routing_manager_base.cpp

implementation/routing/src/event.cpp

There is deletion logic

[hjkcst]

implementation/routing/src/routing_manager_base.cpp implementation/routing/src/event.cpp

There is deletion logic

Hello,007herelsp

I know this is delete logic, I mean not completely delete clean (this has to do with the nature of the smart pointer). Perhaps you can test this by printing the reference count of the cycle event by adding a log at the end of the deletion.
For example, ptr1.use_count ().

thanks,jinkuan

[007herelsp]

implementation/routing/src/routing_manager_base.cpp

add its_event->set_provided(false);

and void event::update_cbk(boost::system::error_code const &error) added the is_provided detection, which is used to exit the cycle_timer

I have tested this code and it can successfully release the event data, but I am not sure if it brings other problems, you can test it

[hjkcst]

I think it needs to be tested by the authorities, so how can the authorities intervene in this modification?