Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display text json #684

Conversation

pavel-ilin
Copy link

⚠️ IMPORTANT: Please do not create a Pull Request without creating an issue first.

All changes need to be discusssed before proceeding. Failure to do so may result in the pull request being rejected.

Please be sure to review our Code of Conduct, Contributing Guidelines, and Support documentation before submitting a pull request.


Please include the issue number the pull request fixes by replacing YOUR-ISSUE-HERE in the text below.

Fixes #665

Summary

Build 'display text' master json for Dutch language.

Details

Modified process_json.py to build nested json file. Right now it process only display text. If this script is ok, I will expand it to Education and Survey.

Test Plan (required)

  • cd /src/python
  • python process_json.py
  • open Dutch.json in same directory

Final Checklist

  • For CoronaTracker, did you bump the version in package.json?
    • Update the second decimal for a major change
    • Update the third decimal for a minor change
    • Numbers can go past 9, e.g. 1.0.9 => 1.0.10
    • For more info, read about Semantic Versioning
  • Did you add any new tests as necessary?
  • Is your PR rebased off the most current master?
  • Have you squashed all commits? (can be done at merge)
  • Did you use yarn not npm? (important!)
  • Did you use Material-UI wherever possible?
  • Did you run yarn lint on the code?
  • Did you run all of your most recent changes locally to make sure everything is working?

ngiangre
ngiangre previously approved these changes Apr 30, 2020
Copy link
Contributor

@ngiangre ngiangre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the output? Should I run this and check it out?

@pavel-ilin
Copy link
Author

What's the output? Should I run this and check it out?

Output is structured as I intended json file. After you run python process_json.py it's create Dutch.json on the same directory.

SomeMoosery
SomeMoosery previously approved these changes Apr 30, 2020
@pavel-ilin
Copy link
Author

I will close this PR without merging because it's outdated.

Check more recent work on the issue #665 in this PRs: #678 #643

@pavel-ilin pavel-ilin closed this May 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEAT] Python scripting: format GSheet csv to json via Google API data pull
3 participants