-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set app default language as language of the user browser settings #690
Merged
AdhamAH
merged 5 commits into
COVID-19-electronic-health-system:master
from
pavel-ilin:pavel-ilin
May 6, 2020
Merged
Set app default language as language of the user browser settings #690
AdhamAH
merged 5 commits into
COVID-19-electronic-health-system:master
from
pavel-ilin:pavel-ilin
May 6, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavel-ilin
requested review from
acthelemann,
AdhamAH and
SomeMoosery
as code owners
May 5, 2020 18:04
SomeMoosery
reviewed
May 5, 2020
SomeMoosery
approved these changes
May 6, 2020
AdhamAH
approved these changes
May 6, 2020
AdhamAH
added a commit
to AdhamAH/Corona-tracker
that referenced
this pull request
May 6, 2020
Survey reminder (COVID-19-electronic-health-system#681) * added daily reminder * bump package/fixed more * update survey reducer test * change bg color of dialog * modify clear survey Onboard small screens fix (COVID-19-electronic-health-system#687) * Onboard small screens fix * Onboard small screens fix * Update package.json Update Corona-tracker docs for ROADMAP-TO-MVP (COVID-19-electronic-health-system#688) * roadmap: clean up typos and reflow list * roadmap: small tweaks * roadmap: add link to open issues by label * readme: add roadmap info section and links * readme: fix COVID-19-electronic-health-system#648 add opencollective shields badge * fix COVID-19-electronic-health-system#649 add twitter and discord badges * readme: move application overview above faq * move wireframe image to design readme * readme: fix COVID-19-electronic-health-system#666 add PanFLUte link * readme: fix COVID-19-electronic-health-system#627 add and cleanup translations refs * update translation readme formatting and links Create `main.yml` (COVID-19-electronic-health-system#689) Merge remote-tracking branch 'upstream/master' into Pulse Set app default language as language of the user browser settings (COVID-19-electronic-health-system#690) * set app default language as language of the use OS * package.js * fix default language setiing * fix rendering with useEffect hook * fix rendering with useEffect hook Update package.json
AdhamAH
added a commit
to AdhamAH/Corona-tracker
that referenced
this pull request
May 6, 2020
* added daily reminder * bump package/fixed more * update survey reducer test * change bg color of dialog * modify clear survey Onboard small screens fix (COVID-19-electronic-health-system#687) * Onboard small screens fix * Onboard small screens fix * Update package.json Update Corona-tracker docs for ROADMAP-TO-MVP (COVID-19-electronic-health-system#688) * roadmap: clean up typos and reflow list * roadmap: small tweaks * roadmap: add link to open issues by label * readme: add roadmap info section and links * readme: fix COVID-19-electronic-health-system#648 add opencollective shields badge * fix COVID-19-electronic-health-system#649 add twitter and discord badges * readme: move application overview above faq * move wireframe image to design readme * readme: fix COVID-19-electronic-health-system#666 add PanFLUte link * readme: fix COVID-19-electronic-health-system#627 add and cleanup translations refs * update translation readme formatting and links Create `main.yml` (COVID-19-electronic-health-system#689) Merge remote-tracking branch 'upstream/master' into Pulse Set app default language as language of the user browser settings (COVID-19-electronic-health-system#690) * set app default language as language of the use OS * package.js * fix default language setiing * fix rendering with useEffect hook * fix rendering with useEffect hook Update package.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All changes need to be discussed before proceeding. Failure to do so may result in the pull request being rejected.
Before submitting a pull request, please be sure to review:
Please include the issue number the pull request fixes by replacing YOUR-ISSUE-HERE in the text below.
Fixes #657
Summary
Following @njordhov advice, default language of the app set by checking web browser settings.
Details
Add default language of the app in
Translation
component with usingwindow.navigator.language
.If user browser language is not found in the backend, by default English language will be used.
Test Plan (required)
yarn start
set default language in your browser
open login page
tested in Chrome and Opera browsers.
Final Checklist
package.json
?1.0.9
=>1.0.10
yarn
notnpm
? (important!)yarn lint
on the code?