Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Circuit decomposition for all ranges #424

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Wout4
Copy link
Collaborator

@Wout4 Wout4 commented Oct 13, 2023

This makes our Circuit decomposition total for all ranges (old decomposition is invalid if the variables take ranges outside of the element bounds).
This makes circuit about 20% slower (from limited testing)

Alternative is to disallow making circuits with variables outside the expected range.

@Wout4 Wout4 linked an issue Oct 13, 2023 that may be closed by this pull request
@Wout4
Copy link
Collaborator Author

Wout4 commented Oct 26, 2023

Did some more timings, and in the positive case it indeed becomes slower, but we might introduce separate positive decompositions to deal with that anyway in the future.

For the negative case it only is slower when you make the variable bounds bigger, so I would argue there is no downside to allowing this since the other options would be to enforce the tight bounds..

@Wout4
Copy link
Collaborator Author

Wout4 commented Jan 19, 2024

blocked since we will first make element a total function

@Wout4 Wout4 added the blocked Pull request blocked by another pull request/issue. label Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked Pull request blocked by another pull request/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reified circuit first element of list is restricted
1 participant