This repository was archived by the owner on Aug 27, 2025. It is now read-only.
Update firstTimeInstall.sh source the cprt_bash_aliases from bashrc#25
Open
Update firstTimeInstall.sh source the cprt_bash_aliases from bashrc#25
Conversation
ConnorNeed
reviewed
Nov 27, 2024
Member
ConnorNeed
left a comment
There was a problem hiding this comment.
Thank you for adding this.
Not sure if we will need it once we get the node management system running since the main aliases we used last year were build, and a handful of launch commands. We have the ./make.sh file for building too. Willing to hear other opinions.
Member
|
Approving from a implementation standpoint. Up to @ChrisRusu1 as to whether this is a feature we want implemented. |
ConnorNeed
approved these changes
Nov 29, 2024
ChrisRusu1
approved these changes
Nov 30, 2024
Contributor
ChrisRusu1
left a comment
There was a problem hiding this comment.
We can add the specific aliases we used last time later on but I like the idea of having it in the repo so everyones got the same aliases
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds some code into the firstTimeInstall.sh to source our own bash aliases file. Has safety checks that will only put one copy of this code into the bashrc and will only try to source our bash alias file if it exists.
Also created a eaCPRT alias to edit the CPRT alias file.