-
Notifications
You must be signed in to change notification settings - Fork 13
feat: move CallGraph into hugr-core #2531
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2531 +/- ##
==========================================
+ Coverage 82.66% 82.68% +0.01%
==========================================
Files 252 252
Lines 46781 46927 +146
Branches 42297 42443 +146
==========================================
+ Hits 38673 38800 +127
- Misses 6058 6066 +8
- Partials 2050 2061 +11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This PR contains breaking changes to the public Rust API. cargo-semver-checks summary
|
//! Compilation passes acting on the HUGR program representation. | ||
pub mod call_graph; | ||
#[deprecated(note = "Re-exported from hugr-core", since = "0.22.3")] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The since
here commits me to making a patch release, ho hum....
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is fine, if 0.22.3
never happens, people will be smart enough to infer this means 0.23
:)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks Alan!
//! Compilation passes acting on the HUGR program representation. | ||
pub mod call_graph; | ||
#[deprecated(note = "Re-exported from hugr-core", since = "0.22.3")] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is fine, if 0.22.3
never happens, people will be smart enough to infer this means 0.23
:)
I'm confused - why does semver complain on this change? EDIT: this is a known issue -> obi1kenobi/cargo-semver-checks#355. We can ignore and override it. |
This is following something of a different path in #2555 (I had to include constants!) so I'm gonna close this, and then do it again with hugr-core "StaticGraph" (or some name like that) and add the |
In the short term, this is likely wanted for an upcoming PR on linking.
In the (only-slightly-)longer term, we're likely to want this to include static function type-arguments, where a Call/LoadFunction can refer to multiple functions (e.g.
foo<bar>(runtime_args)
), which will probably mean adding variants toenum CallGraphEdge
. So....#[non_exhaustive] enum CallGraphEdge
now, making that (anticipated, hypothetical) future change less breaking. (Probably still breaking, though!)hugr-passes
- I think rust-semver checks is wrong here).non_exhaustive
but hugr-passes not.