-
Notifications
You must be signed in to change notification settings - Fork 14
chore: add model-exts conversion check #2613
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2613 +/- ##
==========================================
- Coverage 83.32% 83.07% -0.26%
==========================================
Files 256 255 -1
Lines 50491 48420 -2071
Branches 46014 43943 -2071
==========================================
- Hits 42074 40225 -1849
- Misses 6065 6102 +37
+ Partials 2352 2093 -259
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
hugr-py/tests/conftest.py
Outdated
# Encoding formats to test, indexed by the format name as used by | ||
# `hugr convert --format`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like the compressed ones you added are not included in hugr convert --format
? Could you update this comment accordingly?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Modified the comments to add some more clarity.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Now that we are able to import models in python (#2581) we can enable the roundtrip checks in the
validate
fixture of thehugr-py
tests.I have also added a couple more models to check when writing, mainly JSON with compression and BINARY with no compression. This adds around 5 seconds of running time to the
hugr-py
tests.And I've separated the
test_envelope.py::test_envelope
test case intotest_envelope_binary
(parametrized for eachEnvelopeFormat
andcompression
) andtest_envelope_text
.