-
Notifications
You must be signed in to change notification settings - Fork 13
feat(llvm)!: upgrade to LLVM 20 #2700
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
ss2165
wants to merge
8
commits into
main
Choose a base branch
from
ss/push-zxypysnwkrkm
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2700 +/- ##
==========================================
+ Coverage 83.53% 83.68% +0.14%
==========================================
Files 266 266
Lines 51718 51505 -213
Branches 47184 46971 -213
==========================================
- Hits 43202 43100 -102
+ Misses 6136 6132 -4
+ Partials 2380 2273 -107
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
|
This PR contains breaking changes to the public Rust API. cargo-semver-checks summary |
Main changes are needing to provide types when using opaque pointers New pass manager is not supported by inkwell yet so have to call mem2reg via string interface.
d9d35d8 to
d7173a3
Compare
ab9eca4 to
ffbe031
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main change is opaque pointers not supported from llvm17 onwards.
This means passing pointer type around a lot.
Smaller changes:
Snap diffs are hard to see because of renaming, see commit update snaps for useful diffs
BREAKING CHANGE: LLVM support upgraded to LLVM20, a number of functions now take a type parameter for pointers.