feedback 1

pytket/phir/sharding/shard.py

@@ -9,8 +9,6 @@
 #
 ##############################################################################
 
-from __future__ import annotations
-
 from dataclasses import dataclass
 
 from pytket.circuit import Command
@@ -33,20 +31,4 @@ class Shard:
 
     # A set of the other shards this particular shard depends upon, and thus
     # must be scheduled after
-    depends_upon: set[Shard]
-
-    # def __init__(self,
-    #              primary_command: Command,
-    #              sub_commands: dict[UnitID, list[Command]],
-    #              depends_upon: set[Shard]) -> None:
-
-    #     # The schedulable command of the shard
-    #     self.primary_command = primary_command
-
-    #     # The other commands related to the primary schedulable command, stored
-    #     # as a map of bit handle (unitID) -> list[Command]
-    #     self.sub_commands = sub_commands
-
-    #     # A set of the other shards this particular shard depends upon, and thus
-    #     # must be scheduled after
-    #     self.depends_upon = depends_upon
+    depends_upon: set["Shard"]

ruff.toml

@@ -51,7 +51,10 @@ ignore = [
 
 [per-file-ignores]
 "__init__.py" = ["F401"]  # module imported but unused
-"tests/*"     = ["S101"]  # Use of `assert` detected
+"tests/*"     = [
+    "S101", # Use of `assert` detected
+    "PLR2004" # Magic constants
+  ]
 
 [pydocstyle]
 convention = "google"

tests/test_sharder.py

@@ -21,4 +21,4 @@ def test_ctor(self) -> None:
 
         output = sharder.shard()
 
-        assert len(output) == 3  # noqa: PLR2004
+        assert len(output) == 3