generated from CQCL/pytemplate
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skeleton of Sharding Approach #1
Merged
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
7f41edd
First pass of sharding data types
nealerickson-qtm ea8db4f
first pass
nealerickson-qtm 5678074
Merge branch 'main' into nje-sharding
nealerickson-qtm 60f21be
cleanup
nealerickson-qtm c5bdcb0
trying a fix
nealerickson-qtm b13d489
Fix namespace collision introduced by unneeded __init__.py
qartik 3f52976
small changes
nealerickson-qtm a7c1c68
removing
nealerickson-qtm f759167
feedback 1
nealerickson-qtm 34f045c
rename of method in sharder
nealerickson-qtm c2eb078
removing headers
nealerickson-qtm 1232f14
mistake in deletion
nealerickson-qtm File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
.PHONY: tests, lint | ||
|
||
tests: | ||
pytest -s -x -vv tests/test*.py | ||
|
||
lint: | ||
pre-commit run --all-files |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -16,3 +16,4 @@ where = ["."] | |
pythonpath = [ | ||
"." | ||
] | ||
filterwarnings = ["ignore:::lark.s*"] |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,10 +1,29 @@ | ||
"""This is the main module of the pytket-phir package.""" | ||
""" | ||
NOTE: Just a placeholder to allow convenient testing of the flows | ||
""" | ||
|
||
from pytket.circuit import Circuit | ||
from pytket.qasm.qasm import circuit_from_qasm | ||
|
||
def hello_world() -> str: | ||
"""Print 'Hello, world!' to the console.""" | ||
hw = "Hello, World!" | ||
return hw | ||
from .sharding.sharder import Sharder | ||
|
||
# Load a qasm circuit and parse | ||
# ,=""=, | ||
# c , _,{ | ||
# /\ @ ) __ | ||
# / ^~~^\ <=.,__/ '}= | ||
# (_/ ,, ,,) \_ _>_/~ | ||
# ~\_(/-\)'-,_,_,_,-'(_)-(_) | ||
circuit: Circuit = circuit_from_qasm("tests/data/qasm/baby.qasm") | ||
|
||
print(hello_world()) # noqa: T201 | ||
# https://cqcl.github.io/tket/pytket/api/circuit_class.html | ||
|
||
# Just a little debugging fun | ||
print("Input circuit:") | ||
print(circuit) | ||
print() | ||
|
||
sharding_output = Sharder(circuit).shard() | ||
|
||
print("Sharding output:") | ||
print(sharding_output) |
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,23 @@ | ||
from dataclasses import dataclass | ||
|
||
from pytket.circuit import Command | ||
from pytket.unit_id import UnitID | ||
|
||
|
||
@dataclass | ||
class Shard: | ||
""" | ||
A shard is a logical grouping of operations that represents the unit by which | ||
we actually do placement of qubits | ||
""" | ||
|
||
# The schedulable command of the shard | ||
primary_command: Command | ||
|
||
# The other commands related to the primary schedulable command, stored | ||
# as a map of bit-handle (unitID) -> list[Command] | ||
sub_commands: dict[UnitID, list[Command]] | ||
|
||
# A set of the other shards this particular shard depends upon, and thus | ||
# must be scheduled after | ||
depends_upon: set["Shard"] |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,81 @@ | ||
from pytket.circuit import Circuit, Command, Op, OpType | ||
from pytket.unit_id import UnitID | ||
|
||
from .shard import Shard | ||
|
||
NOT_IMPLEMENTED_OP_TYPES = [OpType.CircBox, OpType.WASM] | ||
|
||
|
||
class Sharder: | ||
""" | ||
The sharder class is responsible for taking in a circuit in TKET representation | ||
and converting it into shards that can be subsequently handled in the | ||
compilation pipeline. | ||
""" | ||
|
||
def __init__(self, circuit: Circuit) -> None: | ||
self._circuit = circuit | ||
print(f"Sharder created for circuit {self._circuit}") | ||
self._pending_commands: dict[UnitID, list[Command]] = {} | ||
self._shards: list[Shard] = [] | ||
|
||
def shard(self) -> list[Shard]: | ||
""" | ||
Performs the sharding algorithm on the circuit the Sharder was initialized | ||
with, returning the list of Shards needed to schedule | ||
""" | ||
print("Sharding begins....") | ||
# https://cqcl.github.io/tket/pytket/api/circuit.html#pytket.circuit.Command | ||
for command in self._circuit.get_commands(): | ||
self._process_command(command) | ||
return self._shards | ||
|
||
def _process_command(self, command: Command) -> None: | ||
""" | ||
Handles a given TKET command (operation, bits, etc) according to the type | ||
and the extant context within the Sharder | ||
""" | ||
print("Processing command: ", command.op, command.op.type, command.args) | ||
if command.op.type in NOT_IMPLEMENTED_OP_TYPES: | ||
msg = f"OpType {command.op.type} not supported!" | ||
raise NotImplementedError(msg) | ||
|
||
if self.should_op_create_shard(command.op): | ||
print(f"Building shard for command: {command}") | ||
self._build_shard(command) | ||
else: | ||
self._add_pending_command(command) | ||
|
||
def _build_shard(self, command: Command) -> None: | ||
""" | ||
Creates a Shard object given the extant sharding context and the schedulable | ||
Command object passed in, and appends it to the Shard list | ||
""" | ||
shard = Shard(command, self._pending_commands, set()) | ||
# TODO: Dependencies! | ||
self._pending_commands = {} | ||
self._shards.append(shard) | ||
print("Appended shard:", shard) | ||
|
||
def _add_pending_command(self, command: Command) -> None: | ||
""" | ||
Adds a pending sub command to the buffer to be flushed when a schedulable | ||
operation creates a Shard. | ||
""" | ||
# TODO: Need to make sure 'args[0]' is the right key to use. | ||
if command.args[0] not in self._pending_commands: | ||
self._pending_commands[command.args[0]] = [] | ||
self._pending_commands[command.args[0]].append(command) | ||
|
||
@staticmethod | ||
def should_op_create_shard(op: Op) -> bool: | ||
""" | ||
Returns `True` if the operation is one that should result in shard creation. | ||
This includes non-gate operations like measure/reset as well as 2-qubit gates. | ||
""" | ||
# TODO: This is almost certainly inadequate right now | ||
return ( | ||
op.type == OpType.Measure | ||
or op.type == OpType.Reset | ||
or (op.is_gate() and op.n_qubits > 1) | ||
) |
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -7,3 +7,4 @@ pytest==7.4.2 | |
ruff==0.0.291 | ||
sphinx==7.2.6 | ||
wheel==0.41.2 | ||
pytket==1.20.1 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
OPENQASM 2.0; | ||
include "hqslib1.inc"; | ||
|
||
qreg q[2]; | ||
creg c[2]; | ||
|
||
h q[0]; | ||
h q[1]; | ||
CX q[0], q[1]; | ||
|
||
measure q->c; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,47 @@ | ||
//@author Raymond Harry Rudy [email protected] | ||
//Bernstein-Vazirani with 10 qubits. | ||
//Hidden string is 111111111 | ||
OPENQASM 2.0; | ||
include "qelib1.inc"; | ||
qreg qr[10]; | ||
creg cr[9]; | ||
h qr[0]; | ||
h qr[1]; | ||
h qr[2]; | ||
h qr[3]; | ||
h qr[4]; | ||
h qr[5]; | ||
h qr[6]; | ||
h qr[7]; | ||
h qr[8]; | ||
x qr[9]; | ||
h qr[9]; | ||
barrier qr[0],qr[1],qr[2],qr[3],qr[4],qr[5],qr[6],qr[7],qr[8],qr[9]; | ||
cx qr[0],qr[9]; | ||
cx qr[1],qr[9]; | ||
cx qr[2],qr[9]; | ||
cx qr[3],qr[9]; | ||
cx qr[4],qr[9]; | ||
cx qr[5],qr[9]; | ||
cx qr[6],qr[9]; | ||
cx qr[7],qr[9]; | ||
cx qr[8],qr[9]; | ||
barrier qr[0],qr[1],qr[2],qr[3],qr[4],qr[5],qr[6],qr[7],qr[8],qr[9]; | ||
h qr[0]; | ||
h qr[1]; | ||
h qr[2]; | ||
h qr[3]; | ||
h qr[4]; | ||
h qr[5]; | ||
h qr[6]; | ||
h qr[7]; | ||
h qr[8]; | ||
measure qr[0] -> cr[0]; | ||
measure qr[1] -> cr[1]; | ||
measure qr[2] -> cr[2]; | ||
measure qr[3] -> cr[3]; | ||
measure qr[4] -> cr[4]; | ||
measure qr[5] -> cr[5]; | ||
measure qr[6] -> cr[6]; | ||
measure qr[7] -> cr[7]; | ||
measure qr[8] -> cr[8]; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
OPENQASM 2.0; | ||
include "hqslib1.inc"; | ||
|
||
qreg q[1]; | ||
creg c[2]; | ||
|
||
h q; | ||
measure q[0]->c[0]; | ||
reset q; | ||
if (c==1) h q; | ||
if (c<1) h q; | ||
if (c>1) h q; | ||
if (c<=1) h q; | ||
if (c>=1) h q; | ||
if (c!=1) h q; | ||
measure q[0]->c[0]; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
OPENQASM 2.0; | ||
include "qelib1.inc"; | ||
qreg q[1]; | ||
creg c[1]; | ||
|
||
h q[0]; | ||
h q[0]; | ||
h q[0]; | ||
h q[0]; | ||
h q[0]; | ||
measure q->c; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
from enum import Enum | ||
|
||
from pytket.circuit import Circuit | ||
from pytket.qasm.qasm import circuit_from_qasm | ||
|
||
|
||
class QasmFiles(Enum): | ||
simple = 1 | ||
cond_1 = 2 | ||
bv_n10 = 3 | ||
baby = 4 | ||
|
||
|
||
def get_qasm_as_circuit(qasm_file: QasmFiles) -> Circuit: | ||
return circuit_from_qasm(f"tests/data/qasm/{qasm_file.name}.qasm") |
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
from pytket.phir.sharding.sharder import Sharder | ||
|
||
from .sample_data import QasmFiles, get_qasm_as_circuit | ||
|
||
|
||
class TestSharder: | ||
def test_ctor(self) -> None: | ||
sharder = Sharder(get_qasm_as_circuit(QasmFiles.baby)) | ||
assert sharder is not None | ||
|
||
output = sharder.shard() | ||
|
||
assert len(output) == 3 |
This file was deleted.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the circuit that we are passing in here suppose to represent a block? Or is there going to be a translation step between circuit -> block? We will need to keep track of each shards that belongs to a block in the future, so I just wasn't sure that is being expressed here properly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think based on the conversation this morning, that for the initial release we are having a single block so it would be 1-to-1. Hopefully I understood that. @dlucchetti interested in your thoughts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does a circuit represent the main block's program? From my understanding, it just provides an abstraction over circuits through wires and operations, but doesn't really provide block level information. Given that we do have just a single flat block, I would assume a block would just contain one circuit compared to N arbitrary circuits if there are conditional expressions.