Don't do strict validation for phirmodel, update angle and duration generation #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qartik
commented
Oct 23, 2023
|
|
||
| Cost: TypeAlias = float | ||
| Layer: TypeAlias = list[Shard] | ||
| Ordering: TypeAlias = list[int] |
There was a problem hiding this comment.
Unsure if this file is the best place to place these alias definitions. I chose this as both phirgen and place_and_route already import it.
Happy to take suggestions. One option is to create a new module with all type declarations.
Asa-Kosto-QTM
approved these changes
Oct 23, 2023
neal-erickson
approved these changes
Oct 23, 2023
| @@ -12,7 +12,7 @@ requires-python = ">=3.10" | |||
| license = {file = "LICENSE"} | |||
| authors = [{name = "Quantinuum"}] | |||
|
|
|||
| dependencies = ["pytket"] | |||
| dependencies = ["phir>=0.1.5", "pytket"] | |||
There was a problem hiding this comment.
Only question here is should the version be pinned to exactly what's in requirements.txt? To prevent any possibility of drift.
There was a problem hiding this comment.
I think, we should be more flexible in pyproject.toml. The pinned version is for reproducible builds, dev environments, etc.
The phir project can add more types/fields, but that may not necessarily require changes to our phir generation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To avoid breakage after merge of CQCL/phir#8.