-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't do strict validation for phirmodel, update angle and duration generation #16
Conversation
|
||
Cost: TypeAlias = float | ||
Layer: TypeAlias = list[Shard] | ||
Ordering: TypeAlias = list[int] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unsure if this file is the best place to place these alias definitions. I chose this as both phirgen
and place_and_route
already import it.
Happy to take suggestions. One option is to create a new module with all type declarations.
@@ -12,7 +12,7 @@ requires-python = ">=3.10" | |||
license = {file = "LICENSE"} | |||
authors = [{name = "Quantinuum"}] | |||
|
|||
dependencies = ["pytket"] | |||
dependencies = ["phir>=0.1.5", "pytket"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only question here is should the version be pinned to exactly what's in requirements.txt
? To prevent any possibility of drift.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think, we should be more flexible in pyproject.toml
. The pinned version is for reproducible builds, dev environments, etc.
The phir
project can add more types/fields, but that may not necessarily require changes to our phir generation.
To avoid breakage after merge of CQCL/phir#8.