Improving shard handling and testing #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qartik
reviewed
Oct 2, 2023
qartik
reviewed
Oct 2, 2023
qartik
reviewed
Oct 2, 2023
qartik
reviewed
Oct 2, 2023
qartik
reviewed
Oct 2, 2023
qartik
reviewed
Oct 2, 2023
qartik
reviewed
Oct 2, 2023
Co-authored-by: Kartik Singhal <[email protected]>
qartik
reviewed
Oct 4, 2023
Jonhas-qtm
approved these changes
Oct 11, 2023
| self._pending_commands: dict[UnitID, list[Command]] = {} | ||
| self._shards: list[Shard] = [] | ||
| print(f"Sharder created for circuit {self._circuit}") |
There was a problem hiding this comment.
Do we want prints vs. some other form of logging? I'm ok with it for first cut merging PR in, but I imagine we won't want to keep these prints as is.
|
|
||
| # Handle dependency calculations | ||
| depends_upon: set[int] = set() | ||
| for shard in self._shards: |
There was a problem hiding this comment.
wondering if dependency creation should be a self contained method. The overall _build_shard method isn't too long but this could be a natural part to break down.
peter-campora
approved these changes
Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shard class being filled out, including some testing for basic use cases.