Professor bug #73
Merged
Professor bug #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikekben
reviewed
Mar 17, 2021
| @@ -51,6 +52,7 @@ | |||
| description: "Saad has gifted the world an unparalleled resource for digging up the deepest and most disguised layers of white supremacy. This book is best experienced as a journey, and the chapters are presented in bite-size lessons so readers can sit with the content, allow for introspection, and engage in essential conversations with friends and family members.", | |||
| url: "https://bookshop.org/a/3433/9781728209807", | |||
| category: "Book") | |||
| =end | |||
There was a problem hiding this comment.
These entries are duplicative of the entries in the CSV file
mikekben
approved these changes
Mar 17, 2021
spinecone
reviewed
Mar 19, 2021
| @@ -4,6 +4,10 @@ | |||
| sessions: 'user/sessions' | |||
| #registrations: 'user/registrations' | |||
| } | |||
|
|
|||
| devise_scope :user do | |||
| get '/users/sign_out' => 'devise/sessions#destroy' | |||
There was a problem hiding this comment.
We'll need to change these GET's to POST's
spinecone
reviewed
Mar 19, 2021
| @@ -2,7 +2,7 @@ class ItemsController < ApplicationController | |||
| #This controller's function is for the items that are stored in the library database. It has operations that create, delete, | |||
| #and edit the items | |||
|
|
|||
| before_action :check_admin, except: [:new, :index, :show, :search, :filter, :not_admin] #WIP must verify that the user is an admin in order for to run any procudure in this controller. An admin | |||
| before_action :check_admin, except: [:create, :check_user, :new, :index, :show, :search, :filter, :not_admin] #WIP must verify that the user is an admin in order for to run any procudure in this controller. An admin | |||
There was a problem hiding this comment.
I don't think we need the WIP comment anymore because it is a WI - done 🎉
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed a few bugs and #72