Fixed some warnings

Author: tsarn

VirtualGameBox/AVR.cpp

@@ -329,7 +329,7 @@ unsigned int AVR::tick() {
                                     decode3d3r(opcode, Rd, Rr);
                                     int16_t vRd = static_cast<int8_t>(rbank.get(Rd));
                                     int16_t vRr = static_cast<int8_t>(rbank.get(Rr));
-                                    uint16_t res = (vRd * vRr) << 1;
+                                    uint16_t res = (uint16_t)(vRd * vRr) << 1;
                                     rbank.set(AVRRegister::R0, res & 0xff);
                                     rbank.set(AVRRegister::R1, res >> 8);
                                     rbank.setSREG(SREG_C, (res >> 15) & 1);
@@ -346,7 +346,7 @@ unsigned int AVR::tick() {
                                     decode3d3r(opcode, Rd, Rr);
                                     int16_t vRd = static_cast<int8_t>(rbank.get(Rd));
                                     uint16_t vRr = rbank.get(Rr);
-                                    uint16_t res = (vRd * vRr) << 1;
+                                    uint16_t res = (uint16_t)(vRd * vRr) << 1;
                                     rbank.set(AVRRegister::R0, res & 0xff);
                                     rbank.set(AVRRegister::R1, res >> 8);
                                     rbank.setSREG(SREG_C, (res >> 15) & 1);

VirtualGameBox/CMakeLists.txt

@@ -35,5 +35,5 @@ target_link_libraries(VirtualGameBox Threads::Threads)
 target_link_libraries(VirtualGameBox Qt5::Widgets)
 
 set(CMAKE_CXX_FLAGS "-Wall -Wextra")
-set(CMAKE_CXX_FLAGS_DEBUG "-g")
+set(CMAKE_CXX_FLAGS_DEBUG "-g3 -O0 -D_GLIBCXX_DEBUG -D_GLIBCXX_DEBUG_PEDANTIC")
 set(CMAKE_CXX_FLAGS_RELEASE "-O3")

VirtualGameBox/Window.cpp

@@ -54,6 +54,8 @@ Window::Window(std::vector<uint8_t> &buf)
     connect(timer, SIGNAL(timeout()), this, SLOT(updateScreen()));
     timer->start(1000 / 30);
 
+    avr.flash.fill(0x00);
+
     for (size_t i = 0; i < buf.size(); i += 2) {
         avr.flash[i >> 1] =
                 (((uint8_t)buf[i + 1]) << 8) | (uint8_t)buf[i];

VirtualGameBox/periph/AVRGPIO.h

@@ -11,7 +11,7 @@
 
 class AVRGPIO {
 protected:
-    uint8_t data, direction;
+    uint8_t data = 0, direction = 0;
 
 protected:
     virtual bool getPinValue(int pin);

VirtualGameBox/periph/AVRTimer16.cpp

@@ -14,6 +14,7 @@ void AVRTimer16::reset() {
     cnt = icr = 0;
     irq = mask = 0;
     ctrl0 = ctrl1 = ctrl2 = 0;
+    ticks = 0;
 }
 
 void AVRTimer16::tick(unsigned int cycles) {

VirtualGameBox/periph/Display.cpp

@@ -76,9 +76,9 @@ void Display::update() {
                         QColor c(((value >> 0) & 1) * 255,
                                  ((value >> 1) & 1) * 255,
                                  ((value >> 2) & 1) * 255);
-                        color.setRed((int) round(c.red() * frac) + color.red());
-                        color.setGreen((int) round(c.green() * frac) + color.green());
-                        color.setBlue((int) round(c.blue() * frac) + color.blue());
+                        color.setRed((int)(c.red() * frac) + color.red());
+                        color.setGreen((int)(c.green() * frac) + color.green());
+                        color.setBlue((int)(c.blue() * frac) + color.blue());
                     }
                 }
             }