Add SpecialWires package, similar to CReg but for Wire and other Wires with multiple ports #1
Conversation
…bined using a given function.
|
Also add Copyright header since all of the other files have it? Should I just copy from one of the other packages here? |
There was a problem hiding this comment.
Should this be in the BlueUtils dir?
I was wondering about that... maybe it makes sense to put it there.... It might be that there is a case to reorganise this a bit... I don't think I am too bothered with the file living straight up in the root for the time being, and we can wonder about this later....
Also add Copyright header since all of the other files have it? Should I just copy from one of the other packages here?
Need to ask Simon about the things that need mentioning in there. Most likely it will be the same header, but could you check with him?
|
|
||
| List #(Wire #(a_bits)) wires <- replicateM (n, wire_module); | ||
| let bit_wires = map (compose (pack, readReg), wires); | ||
| a_bits op_read = unpack (fold (op_b, bit_wires)); |
There was a problem hiding this comment.
IDK to what extent this matters in practice, but since we are using the tree style reduction here, I think we require operations where associativity does not matter (and what about commutativity? We probably don't care?). All in all, I'd just mention that tree of operations in the comments.
|
I was thinking about your claim of "similar to CReg" which I was a bit puzzled by as concurrent regs allow for writes within a cycle to be read in the same cycle on a later interface, and overshadowed by later writes in the cycle etc etc. That got me thinking, and basically I remembered this: https://github.com/CTSRD-CHERI/BlueStuff/blob/master/BlueUtils/SimpleUtils.bsv#L146. I suggest you also pull that guy out of where it currently live and into the SpecialWires package. What do you think? |
JonasAlaif
changed the title
Should this be in the BlueUtils dir?