Add RVC HINT/RES/NSE encs & rework disassembly #51
Annotations
11 warnings
|
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
|
|
Run HLint:
src/InstrCodec.hs#L36
Warning in module InstrCodec: Unused LANGUAGE pragma ▫︎ Found: "{-# LANGUAGE MultiParamTypeClasses #-}" ▫︎ Note: may require `{-# LANGUAGE ConstrainedClassMethods #-}` adding to the top of the file Extension MultiParamTypeClasses is implied by FunctionalDependencies
|
|
Run HLint:
src/InstrCodec.hs#L129
Warning in unscatter in module InstrCodec: Use replicate ▫︎ Found: "take lsb $ repeat False" ▫︎ Perhaps: "replicate lsb False"
|
|
Run HLint:
src/QuickCheckVEngine/Main.hs#L284
Suggestion in main in module Main: Move brackets to avoid $ ▫︎ Found: "(str =~ (fromMaybe \".*\" incReg))\n && (not $ str =~ fromMaybe \"a^\" excReg)" ▫︎ Perhaps: "(str =~ (fromMaybe \".*\" incReg))\n && not (str =~ fromMaybe \"a^\" excReg)"
|
|
Run HLint:
src/QuickCheckVEngine/Main.hs#L284
Suggestion in main in module Main: Redundant bracket ▫︎ Found: "str =~ (fromMaybe \".*\" incReg)" ▫︎ Perhaps: "str =~ fromMaybe \".*\" incReg"
|
|
Run HLint:
src/QuickCheckVEngine/Main.hs#L302
Warning in main in module Main: Use any ▫︎ Found: "or (hasTrap <$> trace)" ▫︎ Perhaps: "any hasTrap trace"
|
|
Run HLint:
src/QuickCheckVEngine/Main.hs#L342
Suggestion in main in module Main: Redundant bracket ▫︎ Found: "if (optSaveAll flags) then (saveDir flags) else Nothing" ▫︎ Perhaps: "if optSaveAll flags then (saveDir flags) else Nothing"
|
|
Run HLint:
src/QuickCheckVEngine/Main.hs#L342
Suggestion in main in module Main: Redundant bracket ▫︎ Found: "if (optSaveAll flags) then (saveDir flags) else Nothing" ▫︎ Perhaps: "if (optSaveAll flags) then saveDir flags else Nothing"
|
|
Run HLint:
src/QuickCheckVEngine/Main.hs#L382
Suggestion in main in module Main: Use void ▫︎ Found: "f t >> return ()" ▫︎ Perhaps: "void (f t)"
|
|
Run HLint:
src/QuickCheckVEngine/Main.hs#L382
Suggestion in main in module Main: Redundant bracket ▫︎ Found: "(numTests <$>)\n . (doCheck (wrapTest <$> (T.genTest testParams template)))" ▫︎ Perhaps: "(numTests <$>)\n . doCheck (wrapTest <$> (T.genTest testParams template))"
|
|
Run HLint:
src/QuickCheckVEngine/Main.hs#L382
Suggestion in main in module Main: Redundant bracket ▫︎ Found: "wrapTest <$> (T.genTest testParams template)" ▫︎ Perhaps: "wrapTest <$> T.genTest testParams template"
|
Loading