Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid type-unsafe use of 'head' #50

Merged
merged 1 commit into from
Jun 7, 2024
Merged

Avoid type-unsafe use of 'head' #50

merged 1 commit into from
Jun 7, 2024

Conversation

PeterRugg
Copy link
Collaborator

@PeterRugg PeterRugg commented Jun 7, 2024

Since the value had come out of split, and the inputs are sanitised by argparse, this wasn't an actual issue, but it was generating some CI warnings.

@PeterRugg PeterRugg requested a review from gameboo June 7, 2024 14:44
Since the value had come out of split, and the inputs are sanitised
by argparse, this wasn't an acutal issue, but it was generating some
CI warnings.
@PeterRugg PeterRugg force-pushed the fix-head-warnings branch from 9e7178a to ecedde5 Compare June 7, 2024 14:45
Copy link
Member

@marnovandermaas marnovandermaas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me.

src/RISCV/ArchDesc.hs Show resolved Hide resolved
@PeterRugg PeterRugg merged commit 2c4184a into master Jun 7, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants