swapped mercurial for git#392
Merged
arichardson merged 3 commits intoCTSRD-CHERI:mainfrom Mar 22, 2024
Merged
Conversation
Member
|
This is the easy bit. The hard bit is dealing with the fact that many users will have an existing gmp directory that's a mercurial checkout and needs replacing with a git one. This patch does not address that. |
Member
|
The easiest approach might just be to use a different directory name (e.g. libgmp) and keep the mercurial checkout untouched |
arichardson
approved these changes
Mar 19, 2024
Member
arichardson
left a comment
arichardson
left a comment
There was a problem hiding this comment.
LGTM, I'll merge this with an updated commit message once CI is happy.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
#391
in
cheribuild/pycheribuild/projects/cross/gmp.pyswappsrepository = MercurialRepository("https://gmplib.org/repo/gmp")forrepository = GitRepository("https://github.com/gmp-mirror/gmp")Reasoning:
in cheribuild/pycheribuild/projects/cross/gmp.py we are using MercurialRepository with a repository of repository = MercurialRepository("https://gmplib.org/repo/gmp") However, the host for this (quite rightly) blocks certain large IP ranges, namely all of Azure and Github Actions runners, this causes any build that has GMP as a dependency to fail.
There is a well maintained mirror hosted on github at https://github.com/gmp-mirror/gmp which maintains the entire hg repositories commit history and contains some additional branches.