-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
QEMU Morello #149
Merged
Merged
QEMU Morello #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think we should not use rebase+merge here but rather create a merge commit once all issues have been addressed. Rebasing and fixing history is rather awkward. |
qwattash
reviewed
Jun 23, 2021
qwattash
reviewed
Jun 23, 2021
qwattash
reviewed
Jun 23, 2021
qwattash
reviewed
Jun 23, 2021
qwattash
reviewed
Jun 23, 2021
qwattash
reviewed
Jun 23, 2021
qwattash
reviewed
Jun 23, 2021
qwattash
reviewed
Jun 23, 2021
qwattash
reviewed
Jun 23, 2021
qwattash
reviewed
Jun 23, 2021
qwattash
reviewed
Jun 23, 2021
qwattash
reviewed
Jun 23, 2021
qwattash
reviewed
Jun 23, 2021
qwattash
reviewed
Jun 23, 2021
qwattash
reviewed
Jun 23, 2021
qwattash
reviewed
Jun 23, 2021
qwattash
reviewed
Jun 23, 2021
qwattash
reviewed
Jun 23, 2021
qwattash
reviewed
Jun 23, 2021
qwattash
reviewed
Jun 23, 2021
qwattash
reviewed
Jun 23, 2021
qwattash
reviewed
Jun 24, 2021
qwattash
reviewed
Jun 24, 2021
qwattash
reviewed
Jun 24, 2021
qwattash
reviewed
Jun 24, 2021
qwattash
reviewed
Jun 24, 2021
One was missing and one was poor style.
This matches RISC-V and avoids using the binutils INSN_* namespace.
This reduces the diff to upstream.
It is impossible to have an otype outside of the valid range with the current compression schemes. Now that we extract the otype from the pesbt bits it's also impossible for cap_get_otype_unsigned() to return such a value.
These helpers are not called by the TCG generated for Morello.
This removes some CAP_cc usages from the Morello helpers.
And factor out a new cap_otype_is_reserved() helper function.
After the latest refactoring we can now drop the TARGET_MORELLO branch.
arichardson
force-pushed
the
qemu-morello-rebased
branch
from
October 12, 2021 13:15
87a1dae
to
d0ac758
Compare
jrtc27
approved these changes
Oct 12, 2021
Most uses appear to assume that LAST_NONRESERVED_OTYPE is a valid non-reserved otype rather than the first reserved one. However, all of those checks are incorrect for Morello, so we should really remove this macro.
jrtc27
reviewed
Oct 12, 2021
Performing comparisons against this constant is likely to cause bugs since Morello allocates otypes from the bottom but MIPS/RISC-V allocate from the top, so any less than/greater than checks are wrong for at least one architecture.
This makes it clear that we are referring the the MIN/MAX numerical value. Previously it was -1 to -16 for MIPS/RISC-V which meant that my implementation of cap_otype_is_reserved() was broken since the check `otype > 0x3ffff && otype <= 0x3fff0` is never true.
This does not corrupt other fields, but they will be truncated silently.
arichardson
force-pushed
the
qemu-morello-rebased
branch
from
October 12, 2021 15:53
b06684c
to
771c788
Compare
jrtc27
approved these changes
Oct 12, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's hope this one didn't break anything... 🤞
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #128
Comments from #148 also still need to be addressed, but otherwise it should mostly be ready for reviewing.