CHERI-RISC-V: slightly rearrange SLTI HINT decoder#180
Open
nwf wants to merge 1 commit intoCTSRD-CHERI:devfrom
Open
CHERI-RISC-V: slightly rearrange SLTI HINT decoder#180nwf wants to merge 1 commit intoCTSRD-CHERI:devfrom
nwf wants to merge 1 commit intoCTSRD-CHERI:devfrom
Conversation
nwf
force-pushed
the
202110-cheri-riscv-hints
branch
from
4053514 to
dde912d
Compare
nwf
force-pushed
the
202110-cheri-riscv-hints
branch
from
dde912d to
d1e9f1e
Compare
jrtc27
reviewed
Nov 12, 2021
Member
jrtc27
left a comment
jrtc27
left a comment
There was a problem hiding this comment.
I guess clang-format and checkpatch don't run on .c.inc... :(
- Restructure the code under the assumption that there will be HINT consumers
other than TCG_LOG_INSTR.
- Document the current and near-term allocations of the opcode space:
- Move the TCG_LOG_INSTR tests to match rs1 == x0, which is the only form that
we have emitted, but we were never ignoring rs1.
- Reserve `SLTI x0, x31, 0xNNN` forms for software's introspective use until
(and if) RISC-V upstream defines something for that use case.
nwf
force-pushed
the
202110-cheri-riscv-hints
branch
from
d1e9f1e to
86fd100
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restructure the code under the assumption that there will be HINT consumers
other than TCG_LOG_INSTR.
Document the current and near-term allocations of the opcode space:
Move the TCG_LOG_INSTR tests to match rs1 == x0, which is the only form that
we have emitted, but we were never ignoring rs1.
Reserve
SLTI x0, x31, 0xNNNforms for software's introspective use until(and if) RISC-V upstream defines something for that use case.
XREF https://github.com/CTSRD-CHERI/cheri-architecture/pull/78