Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove obsolete definition of debug_counter_names #216

Open
wants to merge 1 commit into
base: qemu-experimental-tracing
Choose a base branch
from
Open

Remove obsolete definition of debug_counter_names #216

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions trace_extra/guest_context_tracker.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,14 +51,6 @@ std::unordered_map<qemu_ctx_id, std::shared_ptr<qemu_context_state>,
tuple_hasher<qemu_ctx_id>>
track_state_map;

/*
* Constant mapping of QEMUDebugCounter IDs to counter track names
*/
const std::array<const std::string, QEMU_LOG_INSTR_DBG_MAX> debug_counter_names{
"tb_icount",
"tb_icount_tracing",
};

/* Helper to generate unique IDs for dynamic tracks */
unsigned long gen_track_uuid()
{
Expand Down
10 changes: 0 additions & 10 deletions trace_extra/guest_context_tracker.hh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,9 +61,6 @@ unsigned long gen_track_uuid();
perfetto::protos::pbzero::QEMULogEntryModeSwitch
qemu_cpu_mode_to_trace(qemu_log_instr_cpu_mode_t mode);

extern const std::array<const std::string, QEMU_LOG_INSTR_DBG_MAX>
debug_counter_names;

/*
* Custom track representing a QEMU guest context.
*/
Expand Down Expand Up @@ -216,13 +213,6 @@ struct qemu_fallback_state : public qemu_tracker_state {
perfetto::TrackEvent::EraseTrackDescriptor(track);
}

perfetto::CounterTrack
get_debug_counter_track(QEMUDebugCounter counter_index)
{
return perfetto::CounterTrack(
debug_counter_names[counter_index].c_str(), track);
}

perfetto::Track *get_track()
{
return &track;
Expand Down