[profiler] The Hole is essential object

The hole is not oddball anymore, but it should be still treated as essential object in the heap profiler. (cherry picked from commit 24347db) Bug: v8:14041, chromium:1453710 Change-Id: I867a12307163566d0eb646b16ba097839a4a313e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4590820 Commit-Queue: Toon Verwaest <[email protected]> Reviewed-by: Toon Verwaest <[email protected]> Cr-Original-Commit-Position: refs/heads/main@{#88088} Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4605000 Commit-Queue: Choongwoo Han <[email protected]> Cr-Commit-Position: refs/branch-heads/11.5@{v8#12} Cr-Branched-From: 0c4044b-refs/heads/11.5.150@{#1} Cr-Branched-From: b71d303-refs/heads/main@{#87781}
CTSRD-CHERI · Jun 12, 2023 · 3fed046 · 3fed046
1 parent 87971e7
commit 3fed046
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/src/profiler/heap-snapshot-generator.cc b/src/profiler/heap-snapshot-generator.cc
@@ -2225,7 +2225,8 @@ bool V8HeapExplorer::IsEssentialObject(Object object) {
   }
   Isolate* isolate = heap_->isolate();
   ReadOnlyRoots roots(isolate);
-  return !object.IsOddball(isolate) && object != roots.empty_byte_array() &&
+  return !object.IsOddball(isolate) && object != roots.the_hole_value() &&
+         object != roots.empty_byte_array() &&
          object != roots.empty_fixed_array() &&
          object != roots.empty_weak_fixed_array() &&
          object != roots.empty_descriptor_array() &&