Fixes prediction across all architectures #273
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two bugs found by testing prediction across all architectures:
RNNModel
, but this incompatible so it needs to be disabled. Failing to do this results in an inscrutable error instead of aNotImplementedError
. This is fixed in all locations. In each case I made the decision to place the exception relatively "low" (i.e., more derived) in the class hierarchy, so if someone actually did implementbeam_decode
on these classes everything would just work.Clean-ups done at the same time:
END
and its tag is<E>
.beam_decode
andgreedy_decode
everywhere.