fix: add TX buffer is full check to hasRoom in telemetry#78
Closed
fix: add TX buffer is full check to hasRoom in telemetry#78
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
MARTHA gets stuck if no device is connected for outputting serial data, because the output buffer fills up.
This PR adds a check in telemetry to avoiding adding data to the packet if there wouldn't be enough room for it in the TX buffer.
Summary of Changes
hasRoomupdated to be a member variable and check TX buffer size.Motivation
Testing
Check all that apply:
Building
Checklist