Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Radio to Gui code #69

Open
wants to merge 43 commits into
base: main
Choose a base branch
from
Open

Radio to Gui code #69

wants to merge 43 commits into from

Conversation

rickyrnt
Copy link
Contributor

@rickyrnt rickyrnt commented Apr 8, 2023

No description provided.

@rickyrnt rickyrnt linked an issue Apr 8, 2023 that may be closed by this pull request
Copy link
Contributor

@benjaminwp18 benjaminwp18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of my stuff is linting for this review
I didn't comment on code you didn't change, but a lot of that should really be styled consistently
If you have a conscientious objection to my styling preferences feel free to scream at me; I disagree with google sometimes so it's definitely possible

surface/gui/gui/modules/float_comm.py Outdated Show resolved Hide resolved
float/Tranciever_Reciever/Tranciever_Reciever.ino Outdated Show resolved Hide resolved
float/Tranciever_Reciever/Tranciever_Reciever.ino Outdated Show resolved Hide resolved
float/Tranciever_Reciever/Tranciever_Reciever.ino Outdated Show resolved Hide resolved
float/Tranciever_Reciever/Tranciever_Reciever.ino Outdated Show resolved Hide resolved
float/Tranciever_Reciever/Tranciever_Reciever.ino Outdated Show resolved Hide resolved
float/Tranciever_Reciever/Tranciever_Reciever.ino Outdated Show resolved Hide resolved
Copy link
Contributor

@benjaminwp18 benjaminwp18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix spelling & resolve merge conflicts

float/Tranciever_Reciever/Tranciever_Reciever.ino Outdated Show resolved Hide resolved
float/Tranciever_Reciever/Tranciever_Reciever.ino Outdated Show resolved Hide resolved
@benjaminwp18 benjaminwp18 removed their request for review June 1, 2023 02:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Receive & transmit via the float transceiver
7 participants