Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issues present on iPad but nowhere else. #129

Merged
merged 16 commits into from
Mar 31, 2017
Merged

Fix issues present on iPad but nowhere else. #129

merged 16 commits into from
Mar 31, 2017

Conversation

RhodesPeter
Copy link
Member

@RhodesPeter RhodesPeter commented Mar 30, 2017 •
edited
Loading

Related #112 - Make changes requested by our product owner.

  • We were experiencing things on iPad but not on safari or Chrome on our PCs. This PR should fix some (most) of these issues.
  • This PR also fixes a few easily changeable things that our PO has requested for user testing this week and early next week.

@RhodesPeter
Add border none and colour transparent to range thumb.
00fd207 
This fixes an issue we are seeing on iPad but not anywhere else.
This has been tested on an iPad.

Related #108 and #8
@RhodesPeter
Remove border from email input on /finished page.
93c559b 
Related #108 and #14
@RhodesPeter
Add -webkit-appearance: none; to /finished button
7ae585a 
This should remove the default ipad styling of buttons,
this was something we were only seeing on ipad not on
desktop Safari.

Related #108 and #14
@RhodesPeter
Set all H elements to font-weight: normal.
dd26b86 
This fixes a bug where your font it doubled up when Safari looks
for a bold font and if your font doesn't have one it behaves strangely.
I read about it here: https://css-tricks.com/forums/topic/weird-mobile-safari-font-face-problem-font-doubled-and-offset-to-the-left/

Related #108 and #13
@RhodesPeter
Remove main.css from git ignore to test on Heroku.
f0195ae 
Related #108
@RhodesPeter
Fix syntax in index.js
2eb4d9c 
This was causing the index.js to fail.

Related #112
@RhodesPeter
Add prefixes to flexbox.
1b57d59 
We were experiencing some issues centering images on the
welcome page with flexbox on our PO's ipad.

Related #112
@RhodesPeter
Change formatting of titles in response to PO feedback.
6d30331 
Related #112
@RhodesPeter
Change svg text from font to paths.
9eef6d7 
We don't want the font to change in responce to weather the
OS has the font installed, making text paths will stop this from
happening.

Related #112 and #10.
@RhodesPeter
Change title of app to 'Getting to know you'
20dff7a 
This is a request from our PO.

Related #112
@RhodesPeter
Change the inline svg for balloons.
3639f38 
- This has been changed so that it is the same as the balloons.svg
file is the assests folder with paths rather than a font for the text.

Related #112 and #10
@RhodesPeter
Remove banana from feelings page.
4743a63 
As requested by our PO.

Related #112 and #6
@RhodesPeter RhodesPeter requested a review from skibinska March 30, 2017 14:52
@RhodesPeter
Add main.css back to gitignore.
7cec887 
We removed this to test on Heroku.

Related #112
@RhodesPeter
Remove main.css from GitHub
7d99b58 
This was added to test the branch on Heroku, we don't want this on our master branch.
@des-des des-des assigned RhodesPeter and unassigned des-des Mar 30, 2017
@des-des
Copy link
Collaborator

des-des commented Mar 30, 2017

OKay fix conflicts and assign back

@RhodesPeter RhodesPeter assigned des-des and unassigned RhodesPeter Mar 30, 2017
@RhodesPeter
Copy link
Member Author

Thank you @des-des :)

@des-des des-des merged commit 788a2dd into master Mar 31, 2017
@des-des des-des deleted the WTC-112-FixiPadIssues branch March 31, 2017 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skibinska skibinska skibinska approved these changes

@des-des des-des des-des approved these changes

Assignees

@des-des des-des

Labels
in-review
Projects
None yet
Milestone
Sprint 2 - deadline 14.04.17
Development

Successfully merging this pull request may close these issues.
3 participants
@RhodesPeter @des-des @skibinska