Swap face indexes to achieve parity with vanilla #3254
+4
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The indexing in question was introduced here and this change does indeed change the indexes correspond to Vanilla. Does this break core shaders that operate on entity vertices? I remember at some point we had issues with that. |
|
I am sorry that I am not very familiar with shaders. I think this change only affects the visibility of faces because the only usage of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current face rendering behavior of sodium is different from vanilla due to swapped indexes. There is a demo mod that uses manual face culling at 2190303755/Cube for testing purpose.
Vanilla:
Sodium:
