Fix RSM to Take Worker Thread Budget Into Account #3257
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t into account when scheduling tasks. This caused too many tasks to be submitted, causing weird chunk loading patterns and unresponsive loading of chunks when moving rapidly.
IMS212
approved these changes
Sep 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should be merged before releasing Sodium 0.7, it's a followup to this change, which is missing the
collector.hasBudgetRemaining()check.Fixes an oversight in RSM that wasn't taking the available worker budget into account when scheduling tasks.
This caused too many tasks to be submitted, causing weird chunk loading patterns and unresponsive loading of chunks when moving rapidly.
dev:
dev.demo.small.mov
patch:
patch.demo.small.mov
I did not measure an overall slowdown in how fast chunks are loaded, this just makes their loading pattern more reasonable and more responsible than it was in 0.6.