Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add return-void annotations #6

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

rrehbein
Copy link

@rrehbein rrehbein commented Dec 1, 2022

Add return type hints for void-return methods.

Some of the tooling I'm using was emitting:

Method "League\OAuth2\Client\Provider\AbstractProvider::checkResponse()" might add "void" as a native return type declaration in the future. Do the same in child class "CakeDC\OAuth2\Client\Provider\Cognito" now to avoid errors or add an explicit @return annotation to suppress this message.

@rrehbein
Copy link
Author

rrehbein commented Dec 1, 2022

It appears the project has a minimum PHP 7.3, which supports adding void as a return type, however the current code style appears to not use this feature. If interested, I could add the return types to this PR as well, or would that be against the project's code style?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant