Fix issue #610: keep layout params #665
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Hi, is there anything wrong with this PR? I am new to contributing to open source, this is my first PR and I wonder if taking this long to merge or no getting any comment at all is normal. |
Contributor
|
I haven't gotten around to test this yet. I'm sorry. I'm also not super familiar with that part of the code. Are you using this already in production? |
Contributor
|
I tested a few things out and it does not seem to break anything, thanks! |
Contributor
Author
|
Hey @vanniktech thanks for looking at it and merging. I apologize for the delayed reply, I was on vacations. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #610