fix: escape user search term in getMyQuestions to prevent ReDoS - #1459
fix: escape user search term in getMyQuestions to prevent ReDoS#1459ionfwsrijan wants to merge 1 commit into
Conversation
The q query param was compiled straight into a RegExp, so a crafted term like '(a+)+$' could drive catastrophic backtracking on the shared mongod process. Now the term is treated as literal text (metacharacters escaped) and capped at 200 characters before being compiled. Closes Canopus-Labs#1443
|
Warning Review limit reached
Next review available in: 53 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
Comment |
Problem
GET /api/questions/my-questionscompiles theqquery param directly into a RegExp:A crafted term like
(a+)+$can trigger catastrophic backtracking when MongoDB evaluates the regex against large text fields, stalling the sharedmongodprocess (ReDoS). The term is also unbounded in length, so arbitrarily long inputs create oversized regexes.Fix
escapeRegexhelper that escapes all regex metacharacters ([.*+?^${}()|[\]\\]), so the user term is matched as a literal substring instead of being interpreted as pattern syntax.Files changed
backend/controllers/questionController.js—escapeRegexhelper + literal, length-capped regex construction.backend/tests/questionController.redos.unit.test.js— tests that metacharacters are escaped, nested-quantifier patterns are neutralized, length is capped, and case-insensitivity is preserved.Testing
npx vitest run tests/questionController.redos.unit.test.js— 5/5 passing. Full suite shows no new failures vs. the origin/main baseline.Closes #1443