Skip to content

fix: escape user search term in getMyQuestions to prevent ReDoS - #1459

Open
ionfwsrijan wants to merge 1 commit into
Canopus-Labs:mainfrom
ionfwsrijan:fix/1443-my-questions-redos
Open

fix: escape user search term in getMyQuestions to prevent ReDoS#1459
ionfwsrijan wants to merge 1 commit into
Canopus-Labs:mainfrom
ionfwsrijan:fix/1443-my-questions-redos

Conversation

@ionfwsrijan

Copy link
Copy Markdown
Contributor

Problem

GET /api/questions/my-questions compiles the q query param directly into a RegExp:

const searchRegex = new RegExp(q.trim(), "i");

A crafted term like (a+)+$ can trigger catastrophic backtracking when MongoDB evaluates the regex against large text fields, stalling the shared mongod process (ReDoS). The term is also unbounded in length, so arbitrarily long inputs create oversized regexes.

Fix

  • Added an escapeRegex helper that escapes all regex metacharacters ([.*+?^${}()|[\]\\]), so the user term is matched as a literal substring instead of being interpreted as pattern syntax.
  • Capped the search term at 200 characters before compiling.

Files changed

  • backend/controllers/questionController.jsescapeRegex helper + literal, length-capped regex construction.
  • backend/tests/questionController.redos.unit.test.js — tests that metacharacters are escaped, nested-quantifier patterns are neutralized, length is capped, and case-insensitivity is preserved.

Testing

npx vitest run tests/questionController.redos.unit.test.js — 5/5 passing. Full suite shows no new failures vs. the origin/main baseline.

Closes #1443

The q query param was compiled straight into a RegExp, so a crafted term like
'(a+)+$' could drive catastrophic backtracking on the shared mongod process.
Now the term is treated as literal text (metacharacters escaped) and capped at
200 characters before being compiled.

Closes Canopus-Labs#1443
@coderabbitai

coderabbitai Bot commented Aug 6, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@ionfwsrijan, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 53 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: f7cb7e0d-d45b-4967-96c5-36756f5edf26

📥 Commits

Reviewing files that changed from the base of the PR and between 8acb5b8 and 4d2ffc7.

📒 Files selected for processing (2)
  • backend/controllers/questionController.js
  • backend/tests/questionController.redos.unit.test.js

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

GET /api/question/my-questions compiles the unvalidated q parameter into a MongoDB regex — catastrophic-backtracking ReDoS stalls the shared database

1 participant