Skip to content

fix(flashcard): add ObjectId validation to reviewFlashcard and deleteFlashcard (#1197) #1528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
suhaniiz wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(flashcard): add ObjectId validation to reviewFlashcard and deleteFlashcard (#1197) #1528

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 22 additions & 2 deletions backend/controllers/flashcardController.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
const mongoose = require("mongoose");
const Flashcard = require("../models/Flashcard");

/**
Expand Down Expand Up @@ -145,6 +146,14 @@ const reviewFlashcard = async (req, res) => {
const { rating } = req.body;
const userId = req.user._id;

// Validate ObjectId format before querying database
if (!mongoose.Types.ObjectId.isValid(id)) {
return res.status(400).json({
success: false,
message: "Invalid flashcard ID format",
});
}

if (!rating) {
return res.status(400).json({
success: false,
Expand Down Expand Up @@ -201,6 +210,14 @@ const deleteFlashcard = async (req, res) => {
const { id } = req.params;
const userId = req.user._id;

// Validate ObjectId format before querying database
if (!mongoose.Types.ObjectId.isValid(id)) {
return res.status(400).json({
success: false,
message: "Invalid flashcard ID format",
});
}

const flashcard = await Flashcard.findOneAndDelete({ _id: id, userId });
if (!flashcard) {
return res.status(404).json({
Expand Down Expand Up @@ -242,7 +259,10 @@ const getFlashcardStats = async (req, res) => {
interval: { $gte: 21 },
});

const startOfDay = new Date(now.setHours(0, 0, 0, 0));
// Fix: Clone 'now' before setting hours to avoid in-place mutation of 'now'
const startOfDay = new Date(now);
startOfDay.setHours(0, 0, 0, 0);

const reviewedToday = await Flashcard.countDocuments({
userId,
lastReviewedAt: { $gte: startOfDay },
Expand Down Expand Up @@ -273,4 +293,4 @@ module.exports = {
deleteFlashcard,
getFlashcardStats,
calculateSM2,
};
};
Loading