fix : added max length guard on question and answer fields in ValidateQuestions - #1548
Open
tmdeveloper007 wants to merge 5 commits into
Open
fix : added max length guard on question and answer fields in ValidateQuestions#1548tmdeveloper007 wants to merge 5 commits into
tmdeveloper007 wants to merge 5 commits into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe question session validation schema now limits question text to 5,000 characters and answer text to 10,000 characters. Required-field validation remains unchanged. ChangesQuestion validation
Estimated code review effort: 1 (Trivial) | ~5 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of What Has Been Done
Added max length constraints to
question(5000 chars) andanswer(10000 chars) fields inbackend/Input_validators/ValidateQuestions.js. Previouslyz.string().min(1, ...)was used without any.max()guard.Changes Made
Modified
backend/Input_validators/ValidateQuestions.js:addQuestionToSessionSchema.questions[].question: added.max(5000, "Question must be at most 5000 characters")addQuestionToSessionSchema.questions[].answer: added.max(10000, "Answer must be at most 10000 characters")Impact it Made
Closes #1543
**Note: Please assign this PR to the
tmdeveloper007account.Summary
questionandanswerfields.questionto 5,000 characters.answerto 10,000 characters.Ready to merge.