Skip to content

fix: validate req.body.code in compileResume middleware (#1622) #1722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
suhaniiz wants to merge 3 commits into
base: main
Choose a base branch
from
+16 −10
Open

fix: validate req.body.code in compileResume middleware (#1622) #1722

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4b58bd8
fix: validate req.body.code in compileResume middleware (#1622)
suhaniiz Aug 9, 2026
6dd2aaf
Merge branch 'main' into fix/1622-compile-resume-validation
suhaniiz Aug 9, 2026
d8e43f6
Merge branch 'main' into fix/1622-compile-resume-validation
suhaniiz Aug 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 16 additions & 10 deletions backend/Input_validators/ValidateResume.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,16 +5,6 @@ const { handleValidationError } = require("./ValidateQuestions");
// Schemas
// ==========================================

const mongoose = require("mongoose");
const { handleValidationError } = require('./ValidateQuestions')

const objectId = (label) =>
z
.string()
.min(1, `${label} is required`)
.refine((v) => mongoose.isValidObjectId(v), "Invalid ObjectId format");

// Schema for compileResume request
const compileResumeSchema = z.object({
code: z
.string({
Expand All @@ -38,6 +28,15 @@ const analyzeResumeSchema = z.object({
});

const saveResumeSchema = z.object({
title: z.string({
required_error: "Title is required",
invalid_type_error: "Title must be a string",
}).min(1, "Title is required"),
latexCode: z.string({
required_error: "LaTeX code is required",
invalid_type_error: "LaTeX code must be a string",
}).min(1, "LaTeX code is required"),
resumeId: z.string().optional(),
title: z
.string({
required_error: "Title is required",
Expand Down Expand Up @@ -80,11 +79,18 @@ const validate = (schema) => (req, res, next) => {
// Middleware for compileResume
const validateCompileResume = validate(compileResumeSchema);

// Middleware for analyzeResume (includes file check)
// Middleware for analyzeResume (validates schema + checks file upload)
const validateAnalyzeResume = (req, res, next) => {
const result = analyzeResumeSchema.safeParse(req.body || {});
if (!result.success) {
return handleValidationError(res, result.error);
}
Comment thread
coderabbitai[bot] marked this conversation as resolved.
if (!req.file) {
return res
.status(400)
.json({ success: false, message: "No resume file uploaded" });
}
// Middleware for analyzeResume
const validateAnalyzeResume = async (req, res, next) => {
try {
Expand Down
Loading