Skip to content

fix: DSA sheet progress never persists — accept object completedTopics shape #1729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vedant7007 wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −2
Open

fix: DSA sheet progress never persists — accept object completedTopics shape #1729

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions backend/controllers/userSheetProgressController.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,10 +60,15 @@ exports.saveProgress = async (req, res) => {
});
}

if (completedTopics !== undefined && !Array.isArray(completedTopics)) {
if (
completedTopics !== undefined &&
(typeof completedTopics !== "object" ||
completedTopics === null ||
Array.isArray(completedTopics))
) {
return res.status(400).json({
success: false,
error: "Invalid completedTopics field, must be an array",
error: "Invalid completedTopics field, must be an object",
Comment on lines +63 to +71

@coderabbitai coderabbitai Bot Aug 9, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🗄️ Data Integrity & Integration | 🟠 Major | ⚡ Quick win

Validate completedTopics values against the record contract.

This check accepts any non-null, non-array object. For example, { "0-0-0": "true" } passes validation, but backend/Input_validators/ValidateUserSheetProgress.js:5-10 requires string keys with boolean values. Validate that the value is a plain object and that every property value is boolean before persisting it.

Proposed fix 
   if (
     completedTopics !== undefined &&
-    (typeof completedTopics !== "object" ||
-      completedTopics === null ||
-      Array.isArray(completedTopics))
+    (completedTopics === null ||
+      typeof completedTopics !== "object" ||
+      Array.isArray(completedTopics) ||
+      Object.values(completedTopics).some(
+        (value) => typeof value !== "boolean"
+      ))
   ) {
     return res.status(400).json({
       success: false,
-      error: "Invalid completedTopics field, must be an object",
+      error: "Invalid completedTopics field, must be an object with boolean values",
     });
   }
🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@backend/controllers/userSheetProgressController.js` around lines 63 - 71,
Strengthen the completedTopics validation in the user sheet progress controller
to require a plain object and boolean values for every property, matching the
contract enforced by ValidateUserSheetProgress. Reject non-plain objects and any
entry whose value is not boolean before persisting the record, while preserving
the existing 400 response.

});
}

Expand Down
Loading