Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autogenerated clib core objects #1842

Open
wants to merge 23 commits into
base: main
Choose a base branch
from

Conversation

ischoegl
Copy link
Member

@ischoegl ischoegl commented Jan 24, 2025

Changes proposed in this pull request

  • Add all Cantera "core" objects to experimental CLib
  • APIs for Solution, ThermoPhase, Kinetics, Transport and MultiPhase have reached parity with traditional CLib
  • Additional unit tests are added (go beyond traditional CLib test suite)
  • Some differences of method names compared to traditional CLib API are rolled back - pre-existing inconsistencies are left to be addressed at a later point
  • Logic in _orchestrate.py is simplified

If applicable, fill in the issue number this pull request is fixing

Addresses Cantera/enhancements#220

Checklist

  • The pull request includes a clear description of this code change
  • Commit messages have short titles and reference relevant issues
  • Build passes (scons build & scons test) and unit tests address code coverage
  • Style & formatting of contributed code follows contributing guidelines
  • The pull request is ready for review

@ischoegl ischoegl force-pushed the sourcegen-clib-base branch 2 times, most recently from 3b9ea62 to d2b509a Compare January 25, 2025 23:46
@ischoegl ischoegl force-pushed the sourcegen-clib-base branch 3 times, most recently from 38bcfc7 to 2c9199d Compare January 26, 2025 23:18
@ischoegl ischoegl force-pushed the sourcegen-clib-base branch from 2c9199d to de65446 Compare January 26, 2025 23:19
Copy link

codecov bot commented Jan 26, 2025

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 74.38%. Comparing base (9c3a57c) to head (b51277c).

Files with missing lines Patch % Lines
src/base/ctexceptions.cpp 0.00% 1 Missing and 1 partial ⚠️
src/equil/MultiPhase.cpp 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1842      +/-   ##
==========================================
- Coverage   74.39%   74.38%   -0.01%     
==========================================
  Files         382      382              
  Lines       53354    53358       +4     
  Branches     9030     9032       +2     
==========================================
  Hits        39691    39691              
- Misses      10608    10611       +3     
- Partials     3055     3056       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ischoegl ischoegl force-pushed the sourcegen-clib-base branch from de65446 to 30bb2b7 Compare January 27, 2025 03:53
@ischoegl ischoegl force-pushed the sourcegen-clib-base branch from 30bb2b7 to b51277c Compare January 27, 2025 03:57
@ischoegl ischoegl changed the title Autogenerated clib base objects Autogenerated clib core objects Jan 27, 2025
@ischoegl ischoegl marked this pull request as ready for review January 27, 2025 04:08
@ischoegl ischoegl requested a review from a team January 27, 2025 04:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant