MagicStack: use Multimap for Spells Cast#11154
Draft
Hanmac wants to merge 1 commit into
Draft
Conversation
Contributor
Author
|
@tool4ever @MostCromulent for this i probably need to copy the LKI again to replace the oldPlayer with newPlayer (and maybe the host cards too?) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Still WIP
I'm refactoring how "ThisTurnCast" stuff is stored.
If it is done as ListMultimap, using Player as Map-Key, then we don't need extra counting.
and if we store ThisGameCast too, then we can clean up some other stuff.