Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LinkedAbilities V2 #143

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

LinkedAbilities V2 #143

wants to merge 2 commits into from

Conversation

Hanmac
Copy link
Contributor

@Hanmac Hanmac commented Apr 26, 2022

This is my current Draft for Linked Abilities

abilities are linked if they share the same path of Static Ability interfaces (currently Pump/Animate aren't count, these should be static Abilities too)

Current Problem:

  • Cards that refer to Original Host because they cause problems which card is meant by this (examples follow later)

Original Host example:

Case A:

  • equip Creature with Blinding Powder
  • Creature gains the ability
  • Original Host is the Equipment

Case B:

  • Play Copy Artifact, copying Blinding Powder and equip it to second Creature
  • second Creature gains ability
  • Original Host needs to be the Copy Artifact

Case C:

  • put a +1/+1 counter on first creature, then play Experiment Kraj
  • Experiment Kraj should gain the ability of the first Creature
  • The Original host needs to be the Original Equipment

@Hanmac
Copy link
Contributor Author

Hanmac commented Apr 26, 2022

Problem for View:

  • stuff like ExiledWith will not be a list per Card any more, but a Table
  • CardTraits can access these table by their LinkedAbilityKey (currently a List of StaticAbilityInterface)
  • For Card descriptions: the Card can display the Table Info for an empty LinkedAbilityKey, meaning these are the ones the card inherently has
  • For CardTrait descriptions: the Card Trait may show which the of them are only for these special trait. like which cards are exiled for the abilities of Sisters of Stone Death

@Hanmac
Copy link
Contributor Author

Hanmac commented Apr 26, 2022

Another Problem is Linked Abilities between two objects (for example a Card and its emblem)

The Tibalt, Cosmic Impostor creates an Emblem which should care about the Cards Exiled by the Original Card.
if the Planeswalker is removed, the Emblem should still track the cards which where exiled.
if the Planeswalker is cast again, a new emblem is created and both emblems should track cards independently

@github-actions
Copy link

This PR has not been updated in a while nad has been marked on stale. Stale PRs will be auto closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
keep no stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant