Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add webp support for cards images #1802

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

add-le
Copy link
Contributor

@add-le add-le commented Nov 4, 2022

Add support webp format to the cards images :
Give 25% to 50% smaller image size for same quality as jpg.
Can reduce the cache folder to 25% to 50% its size, for android support can be a good idea.

https://developers.google.com/speed/webp
https://developers.google.com/speed/webp/docs/webp_study

If you find the good settings to convert all superLQ's kevlahnota to webp, without losing much quality, you can achieve near to 30-35% reduce size.

  • Need to check if it's work for token and crop images too

Resolves #643

@tool4ever tool4ever added the GUI label Nov 4, 2022
@kevlahnota
Copy link
Contributor

kevlahnota commented Nov 4, 2022

Change title to add webp support for desktop version, mobile version uses libgdx and it doesn't support webp. There's a webp textureloader here: https://github.com/ZumiKua/libgdx-webp-loader
But you need to modify how it load images.

@add-le add-le marked this pull request as draft November 6, 2022 10:06
Copy link
Contributor Author

@add-le add-le left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kevlahnota e37f652 Is it the right way to add the lib loader ? I don't know too much about maven and this gdx system. I don't think I know how it works.

@github-actions
Copy link

This PR has not been updated in a while nad has been marked on stale. Stale PRs will be auto closed

@add-le
Copy link
Contributor Author

add-le commented May 19, 2023

Still on it

@github-actions
Copy link

This PR has not been updated in a while nad has been marked on stale. Stale PRs will be auto closed

@Hanmac
Copy link
Contributor

Hanmac commented Aug 30, 2023

@kevlahnota can you conment on this?

@Hanmac Hanmac reopened this Aug 30, 2023
@github-actions
Copy link

This PR has not been updated in a while nad has been marked on stale. Stale PRs will be auto closed

@Hanmac Hanmac added keep no stale and removed no-pr-activity labels Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GUI keep no stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Image support for webp
5 participants