Bunch of fixes #1963
Merged
Bunch of fixes #1963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tool4ever
added
AI
Agetian
approved these changes
Nov 24, 2022
|
Looks good and reasonable to me :) 👍 |
|
@tool4ever you could pick up more changes from that timestamp rework branch like the unneeded check for "can be targeted" in the GameEffects, the MagicStack should already handle that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm kind of hoping this speeds the AI up a bit, as the
canPlaycheck was being called lots of times and can also get complex in some scenarios.(There's no reason to provide it with fully updated View as its spell selection is thankfully not done by iterating via some kind of GUI interaction 😄 )
Cherry-picked phasing fix from Timestamp rework #117 and extended it, e.g. phased out Haunted Plate Mail will no longer become animated or still be able to attach
Fix Out of Time counting cards with CantPhaseOut