Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump org.testng:testng from 7.4.0 to 7.5.1 in /forge-game #5283

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github May 23, 2024

Bumps org.testng:testng from 7.4.0 to 7.5.1.

Release notes

Sourced from org.testng:testng's releases.

TestNG v7.5.1

What's Changed

New Contributors

Full Changelog: testng-team/testng@7.5...7.5.1

Changelog

Sourced from org.testng:testng's changelog.

Current (7.11.0) Fixed: GITHUB-3028: Execution stalls when using "use-global-thread-pool" (Krishnan Mahadevan) Fixed: GITHUB-3122: Update JCommander to 1.83 (Antoine Dessaigne)

7.10.2 Fixed: GITHUB-3117: ListenerComparator doesn't work (Krishnan Mahadevan)

7.10.1 Fixed: GITHUB-3110: Update from testng 7.9.0 to 7.10.0 break maven build with junit5 (Krishnan Mahadevan)

7.10.0 Fixed: GITHUB-3000: Method predecessors lookup and/or method sorting is broken in certain inheritance and naming setups (Krishnan Mahadevan) Fixed: GITHUB-3095: Super class annotated with ITestNGListenerFactory makes derived test class throw TestNGException on execution (Krishnan Mahadevan) Fixed: GITHUB-3081: Discrepancy with combination of (Shared Thread pool and Method Interceptor) (Krishnan Mahadevan) Fixed: GITHUB-2381: Controlling the inclusion of the listener at runtime (Krishnan Mahadevan) Fixed: GITHUB-3082: IInvokedMethodListener Iinvoked method does not return correct instance during @​BeforeMethod, @​AfterMethod and @​AfterClass (Krishnan Mahadevan) Fixed: GITHUB-3084: Document project's PGP artifact signing keys (Krishnan Mahadevan) Fixed: GITHUB-3079: Associate a unique id with every test class object instantiated by TestNG (Krishnan Mahadevan) Fixed: GITHUB-3040: replace the usages of synchronized with ReentrantLock (Krishnan Mahadevan) Fixed: GITHUB-3041: TestNG 7.x DataProvider works in opposite to TestNG 6.x when retrying tests. (Krishnan Mahadevan) Fixed: GITHUB-3066: How to dynamically adjust the number of TestNG threads after IExecutorFactory is deprecated? (Krishnan Mahadevan) New: GITHUB-2874: Allow users to define ordering for TestNG listeners (Krishnan Mahadevan) Fixed: GITHUB-3033: Moved ant support under own repository https://github.com/testng-team/testng-ant (Julien Herr) Fixed: GITHUB-3064: TestResult lost if failure creating RetryAnalyzer (Krishnan Mahadevan) Fixed: GITHUB-3048: ConcurrentModificationException when injecting values (Krishnan Mahadevan) Fixed: GITHUB-3050: Race condition when creating Guice Modules (Krishnan Mahadevan) Fixed: GITHUB-3059: Support the ability to inject custom listener factory (Krishnan Mahadevan) Fixed: GITHUB-3045: IDataProviderListener - beforeDataProviderExecution and afterDataProviderExecution are called twice in special setup (Krishnan Mahadevan) Fixed: GITHUB-3038: java.lang.IllegalStateException: Results per method should NOT have been empty (Krishnan Mahadevan) Fixed: GITHUB-3022: Remove deprecated JUnit related support in TestNG (Krishnan Mahadevan)

7.9.0 Fixed: GITHUB-2019: Total thread count in testng parallel tests with dataproviders (Krishnan Mahadevan) Fixed: GITHUB-3006: ITestResult injected at @​AfterMethod incorrect when a configuration method failed (Krishnan Mahadevan) Fixed: GITHUB-2980: Data Provider Threads configuration in the suite don't match the documentation (Krishnan Mahadevan) Fixed: GITHUB-3003: BeforeClass|AfterClass with inheritedGroups triggers cyclic dependencies (Krishnan Mahadevan) New: Added @​Inherited to the Listeners annotation, allowing it to be used in forming meta-annotations. (Pavlo Glushchenko) Fixed: GITHUB-2991: Suite attributes map should be thread safe (Krishnan Mahadevan) Fixed: GITHUB-2974: Command line arguments -groups and -excludegroups override defined groups in a suite xml file (dr29bart) Fixed: GITHUB-2961: "Unexpected value: 16" error when multiple beforeMethod config methods with firstTimeOnly property run before a test (Krishnan Mahadevan) Fixed: GITHUB-2904: Add location of docs Github to readme and contributions page (Mohsin Sackeer) Fixed: GITHUB-2934: Parallel Dataproviders & retries causes test result count to be skewed (Krishnan Mahadevan) Fixed: GITHUB-2925: Issue in ITestcontext.getAllTestMethods() with annotation @​BeforeSuite (Krishnan Mahadevan) Fixed: GITHUB-2928: The constructor of TestRunner encountered NBC changes in 7.8.0 (Krishnan Mahadevan) Fixed: GITHUB-581: Parameters of nested test suites are overridden(Krishnan Mahadevan) Fixed: GITHUB-727 : Fixing data races (Krishnan Mahadevan) Fixed: GITHUB-2913: Maps containing nulls can be incorrectly considered equal (Alex Heneveld)

7.8.0 Fixed: GITHUB-2906: Generate testng-results.xml per test suite (Krishnan Mahadevan)

... (truncated)

Commits
  • 7ddeadb Attempting Release 7.5.1
  • 18810fc Cherrypick - 47afa2c8a29e2cf925238af1ad7c76fba282793f to 7.5 release
  • f264982 Enable ParallelSuiteTest (#2687)
  • 290532e Fix: AfterGroups config annotation does not consider retries for tests (#2690)
  • 2a756e5 Merge pull request #2688 from dsankouski/implement_yaml_load_classes_flag
  • 3c964b8 Review fixes
  • a1f2e3f Yaml parser: implement loadClasses flag
  • e8f17fe Allow ITestObjectFactory injection via listeners (#2677)
  • db17f3c Include all data driven tests for reporting skips
  • 4c28cd6 Adding contributing guidelines to templates.
  • Additional commits viewable in compare view

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
    You can disable automated security fix PRs for this repo from the Security Alerts page.

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

Bumps [org.testng:testng](https://github.com/cbeust/testng) from 7.4.0 to 7.5.1.
- [Release notes](https://github.com/cbeust/testng/releases)
- [Changelog](https://github.com/testng-team/testng/blob/master/CHANGES.txt)
- [Commits](testng-team/testng@7.4.0...7.5.1)

---
updated-dependencies:
- dependency-name: org.testng:testng
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label May 23, 2024
@Hanmac
Copy link
Contributor

Hanmac commented May 23, 2024

@tehdiplomat looks like we can't bump the testng dependency because of Powermock stuff?

Maybe @allentiak can look into it too?

@allentiak
Copy link
Member

allentiak commented Jun 9, 2024

@Hanmac @tehdiplomat

Well, that's one of the reasons I originally opened #4942 ...
It's an step in that direction.

But no one approved it...

@tehdiplomat
Copy link
Contributor

I mean. 4942 is failing the tests, so even if it got approved its not going to get merged...

@allentiak
Copy link
Member

allentiak commented Jun 9, 2024

I mean. 4942 is failing the tests, so even if it got approved its not going to get merged...

Have you actually read the code?
That PR is designed to fail those tests in order to raise awareness.
That's why they are marked as "optional"...

UPDATE: Here, I was referring to 4938. You were referring 4942. My bad.

@allentiak
Copy link
Member

allentiak commented Jun 9, 2024

I will correct myself: 4942 4938 adds those failing tests on purpose.
The fact that they fail will help raise awareness to the fact that other parts of the code need to be changed.

@allentiak
Copy link
Member

Sorry. I meant #4938.

@allentiak
Copy link
Member

@tehdiplomat You're right: #4942 is failing the tests.
I will have to review it.

My question is: assuming I make it pass the tests...
Would it be merged?

@tehdiplomat
Copy link
Contributor

I don't have any problems with #4942 assuming the Android build doesn't get broken. I don't think anyone is clamoring for a testing library over another.

Copy link

This PR has not been updated in a while nad has been marked on stale. Stale PRs will be auto closed

@Hanmac Hanmac added keep no stale and removed no-pr-activity labels Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file keep no stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants